Skip to content

chore(deps): update and group mshv crates together - #1813

Open
simongdavies wants to merge 1 commit into
mainfrom
sdavies-microsoft-mshv-dependency-grouping
Open

chore(deps): update and group mshv crates together#1813
simongdavies wants to merge 1 commit into
mainfrom
sdavies-microsoft-mshv-dependency-grouping

Conversation

@simongdavies

Copy link
Copy Markdown
Member

Summary

  • Use mshv-bindings and mshv-ioctls 0.7.1 together. Mixing 0.6 and 0.7 creates incompatible binding types at the ioctl boundary.
  • Group mshv-* Cargo updates in Dependabot.

Supersedes #1786 and #1785.

Validation

  • Linux just clippy passes with all targets and features.
  • The dependency graph contains one mshv-bindings version, 0.7.1.
  • Full runtime validation is incomplete. The initial test run lacked prebuilt guest binaries. Building them hit a Windows/WSL submodule-path error in hyperlight-libc.

Use mshv-bindings and mshv-ioctls 0.7.1 together to keep their shared types compatible. Group mshv-* Dependabot updates.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 9, 2026 09:39
@simongdavies simongdavies added kind/dependencies For PRs that update dependencies or related components ready-for-review PR is ready for (re-)review labels Sep 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

It updates hypervisor boundary dependencies and the PR notes runtime validation is incomplete, so a human should confirm end-to-end behavior.

Pull request overview

Updates Linux MSHV support dependencies in hyperlight-host so mshv-bindings and mshv-ioctls move forward together (avoiding mismatched binding types at the ioctl boundary), and configures Dependabot to group future mshv-* crate updates into a single PR.

Changes:

  • Bump mshv-bindings and mshv-ioctls dependency requirements in src/hyperlight_host from 0.6 to 0.7.
  • Update Cargo.lock to mshv-bindings/mshv-ioctls 0.7.1.
  • Add a Dependabot group to bundle mshv-* Cargo updates.
File summaries
File Description
src/hyperlight_host/Cargo.toml Updates Linux-target optional MSHV crate versions to the 0.7 line.
Cargo.lock Locks both mshv-* crates to 0.7.1.
.github/dependabot.yml Groups mshv-* cargo dependency updates into one Dependabot PR.
Review details
  • Files reviewed: 2/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/hyperlight_host/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/dependencies For PRs that update dependencies or related components ready-for-review PR is ready for (re-)review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants