Arena/01a1022a affinescript - #776
Merged
Merged
Conversation
tests/codegen-deno/dom_startup_error.affine says `use Dom::{VNode, div, h1,
p, text}`. Module_loader.flatten_imports inlined exactly those decls — but
stdlib/Dom.affine's div/h1/p are one-line wrappers around Dom's own
`pub fn h(...)`. `h` was never named by the import list, so it was left out of
the flattened program and the emitted module called an undefined `h`:
`ReferenceError: h is not defined`. ImportGlob/ImportSimple already inline
every public decl for this reason; ImportList was the odd one out.
Close over the named decls' free variables until a fixpoint, pulling in the
module's own value decls (private helpers included — a public wrapper may
delegate to one) in dependency order. Aliased items keep their behaviour:
the closure runs on the original names, then renaming is applied.
To share the walker instead of adding a fourth private copy (codegen.ml had
one; borrow.ml has another), move find_free_vars into ast.ml and re-export it
from codegen.ml for the existing call sites. (Codegen depends on
Module_loader, so the loader could not reach the copy where it lived.)
Verified locally: the emitted-module call pattern is what the harness died
on; the fix makes `h` part of the flattened program. Full verification needs
the OCaml build in CI.
Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
…`use` Next link in the same chain as the previous commit. With `h` inlined, the emitted module moved on to `ReferenceError: VText is not defined`: stdlib/Dom.affine's `text(content)` returns `VText(content)`, i.e. a constructor of Dom's own `pub enum VNode`, and flatten_imports carries no type decls at all — the #138 note says imported TYPE decls were deliberately dropped because re-emitting the prelude's Option/Result constructors produced duplicate `const Some` declarations under node. So the closure now also carries an enum when a constructor of it is referenced, with the #138 hazard closed rather than ignored: Some/None/Ok/Err are never carried, because every non-wasm backend preamble already provides them. That narrows type-carrying to user enums a preamble cannot supply, which is exactly what a consumer hits with `use Dom::{div}`. Also let a locally-declared type name suppress a same-named import, the same rule local functions and constants already follow. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
The cascade these probes existed for has resolved: every step of the build job now reports a conclusion on its own, and all of them pass — including the three steps (native Bun-ESM, face transformers, issue references) that had never once executed as steps because they sat behind a failing one. Delete the two probe workflows and the annotation-dumping script, and drop the `[diag]` step that invoked it from ci.yml. Repoint the E2E comment that cited the probe, keeping its measured variant table — that evidence is the fix's justification and should not travel with a deleted tool. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (8)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Type of change
How has this been verified?
Checklist
git commit -S).SPDX-License-Identifier(code/configMPL-2.0,prose
CC-BY-SA-4.0); I did not relicense existing files.Notes for reviewers