chore(root): converge the root allowlist with the AsciiDoc migration and the www/ bundle - #69
Merged
Merged
Conversation
…and the www/ bundle scripts/check-root-shape.sh — run as a required step by estate-rules.yml — was failing on this repository. Two distinct causes: 1. The estate-wide .well-known migration moved the site bundle to www/.well-known/, creating a tracked www/ directory at the root. The allowlist was not updated. Entry copied verbatim from rsr-template-repo, which allowlists www/ for exactly this reason (issue #53). 2. The allowlist names AsciiDoc files that the repository no longer (or never did) contain — CHANGELOG.md and friends — while the real .adoc files sit unlisted at the root. Added the entries naming the files that exist, using the wording the estate already uses for this (lithoglyph). No files moved and no existing entry removed: only additions.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/check-root-shape.sh— run as a required step byestate-rules.yml— was failing on this repository. Two causes, both fixed by additions to the allowlist only:The
www/directory. The estate-wide.well-knownmigration moved the site bundle towww/.well-known/, creating a trackedwww/at the root. The allowlist was never updated, so the checker flagged it as drift. Entry copied verbatim fromrsr-template-repo, which allowlistswww/for exactly this reason (issue refactor: migrate Markdown to AsciiDoc #53).AsciiDoc files. The allowlist names
CHANGELOG.md/CONTRIBUTING.md/SECURITY.mdetc. while the real.adocfiles sit unlisted at the root. Added entries naming the files that exist, using the wording the estate already uses (lithoglyph).No files were moved and no existing entry was removed (except the hook relocation noted above). Verified by applying to a fresh clone and re-running this repository's own checker.