-
Notifications
You must be signed in to change notification settings - Fork 0
Sync Telescope, Tinker, Wayfinder and Laravel documentation updates #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
9a4e585
Port Telescope's end-to-end batch watcher test
binaryfire 1beb357
Disable npm install scripts for Telescope's assets
binaryfire ee5fb7d
Port Telescope's duplicate reservation job test
binaryfire 318a3f8
Update Telescope's axios and moment build dependencies
binaryfire f9fbcfc
Consolidate Telescope's CSP nonce tests under upstream's name
binaryfire 524f8be
Add Telescope's list and show commands
binaryfire c98fd7b
Cancel Telescope's in-flight dashboard requests between screens
binaryfire ef61ce6
Hide set-cookie headers in Telescope's provider stub
binaryfire 0caf0a1
Record the name of a scheduled task's timezone object in Telescope
binaryfire d9d8956
Preview the right lines for exceptions near the top of a file
binaryfire 0ebfc0d
Record closure middleware by name in Telescope requests
binaryfire fab0afa
Document Telescope's differences from Laravel
binaryfire 51134cd
Use a real shell in Tinker's class alias tests
binaryfire a46d47a
Record the Reverb, Scout, Telescope and Tinker sync checkpoints
binaryfire ce3d42d
Track Wayfinder's next branch and note how Laravel docs are synced
binaryfire bd4e628
Keep tracking Wayfinder's main branch
binaryfire 8f37f29
Raise Wayfinder's happy-dom minimum to 20.8.9
binaryfire 87b16e4
Sync Wayfinder main and build the HTTP kernel before providers boot
binaryfire 7316c38
Raise the worker memory limit in Telescope's batch watcher test
binaryfire 486051d
Bring Laravel documentation updates into the first group of pages
binaryfire 0881b01
Bring the Permission README in line with the package README format
binaryfire 3cf5542
Fix stale and failed entry loads in the Telescope dashboard
binaryfire 0f9f0d3
Preserve recorded values in Telescope console output
binaryfire a2969eb
Correct the Telescope CSP nonce and DatabaseRefreshed docs
binaryfire 2217eae
Keep console formatting from altering recorded data
binaryfire File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OutputFormatter::escape()prepares text for Symfony's console formatter, buttwoColumnDetailrenders through Termwind and already HTML-escapes its values. A table comment such as<info>Pending</info>will display with added escape characters instead of its original text. The same problem affects column defaults here and the escaped values indb:showandmodel:show.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an issue. The escape only adds a backslash before
<and>, and the console formatter removes it again when the line is written, so plain values such asPendingare unchanged. I rendered values through bothtwoColumnDetailand the bullet list:Pending,a < b,x > 0 && yandTom & Jerrydisplay exactly as stored, and<info>Pending</info> a\>b, which used to display asPending a>b, now displays unchanged. The newDatabaseConsoleOutputTestandModelInspectorTestcases assert the rendered text.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right — my original concern was incorrect.
OutputFormatter::escape()is appropriate here: the console formatter removes the protective backslashes when rendering while preserving literal style-looking text and comparison operators. The rendered cases and addedDatabaseConsoleOutputTest/ModelInspectorTestcoverage confirm thattwoColumnDetailand bullet-list output match the stored values, so this is not an issue.