[imaustink]

Summary

Webhook behaviour is now defined entirely by two CRDs, replacing IntegrationRoute and the hard-coded ai-triage/ai-review logic. ai-triage and ai-review are now just example EventTrigger instances. ADR 0048 supersedes 0024 and amends 0025. The contract is in docs/event-triggers.md.

• EventSource: where events come from.
  • A webhook source is served at POST /webhooks/<name>. The gateway verifies the raw bytes with hmacSha256, slackV0 or bearer before parsing anything.
  • A cron source has a schedule. core-controller turns it into an owned CronJob.
  • An optional sender block resolves and checks who sent the event (for GitHub: team or collaborator membership, and bots are dropped).
  • Every source produces the same normalized envelope.
• EventTrigger: what an event does.
  • match.cel decides whether it fires, and params extracts values with CEL.
  • The target is exactly one of the orchestrator, a skill, an agent or a tool.
  • Also: promptTemplate, a sessionKey template, priority, and readOnly.
  • Replies are declared on the trigger: reply.github (ack, session page, result, removeLabel) and reply.http (an optionally signed callback).
• Both engines: LangGraph uses cel-js and Temporal uses cel-go. A shared fixture suite (packages/event-triggers/fixtures/cel-parity.json) checks they agree.
• Read-only:
  • It is now a structured field: readOnly on AgentRun and ToolRun, passed to agents as AGENT_READ_ONLY and TOOL_READ_ONLY.
  • It stays on for later turns in the same session, and those turns get no write credentials.
  • The SWE-ENFORCED-MODE: review-only prompt sentinel is deleted.
• Cron authentication: each cron source gets its own ServiceAccount. The tick presents a short-lived token minted for the gateway's audience, and the gateway checks it with TokenReview.
  • There is no shared secret, so the chart renders the same under Helm and Argo.
  • One source's identity can never tick another source.
• Charts and examples:
  • The four route templates and the ai-triage/ai-review code paths are deleted.
  • Thirteen example CRs replace them as bare manifests in examples/event-triggers/, outside every chart: 5 sources (GitHub, Slack, CI, generic HMAC, nightly cron) and 8 triggers covering all four target types. Apply with kubectl apply -n <ns> -k examples/event-triggers.
  • Production installs its GitHub source and four ai-triage/ai-review triggers through the agent-controller chart's extraManifests. They are generated from the examples, render the same 5 objects the chart did, and keep the GitHub webhook URL unchanged.
  • e2e applies the examples through a kustomize overlay (e2e/manifests/event-triggers) that only swaps in stubs, e2e Secrets and fake-sink replies.
  • The umbrella chart version is now 0.7.0.

Behaviour changes

• A trigger that targets a tool now reports failed when the tool fails, in both engines.
• /invoke with an event returns 200 ignored when no trigger matches (no turn starts), 422 when params fail, and 202 with {trigger: {name, sessionId, reply}} on a match.
• The orchestrator retries its NATS connection, so it no longer crash-loops when a deploy restarts NATS and Qdrant alongside it.

Deploy notes

• release.yml deletes the retired integrationroutes CRD.
• The gateway gains a ClusterRole whose only permission is create on tokenreviews. TokenReview is cluster-scoped, so a namespaced Role can't grant it.

Test plan

• Unit tests: all TS workspaces, packages/event-triggers (122 tests including the CEL parity fixtures), the Temporal engine's go test ./..., core-controller envtest, and lint.
• E2E on minikube with the Temporal engine: all event-trigger specs pass.
  • Specs: github, readonly, filtering, verification, reply-http, cron, invoke and status.
  • These cover every verification scheme, every target type, sticky read-only, signed HTTP replies, cron (manual tick, scheduler, suspend, delete) and ServiceAccount tick authentication.
• E2E on minikube with the LangGraph engine: all event-trigger specs pass.
• After the switch to ServiceAccount tick auth, the cron and verification specs were rerun on Temporal (17 of 17 pass). The full suites were not rerun.

Known failures that predate this branch

• mcp-broker-contract fails: its expectations went stale when main's e4436ff added hash suffixes to MCP tool ids.
• Resilience "recovers the reply" fails in Temporal mode: if the orchestrator pod handling a turn dies mid-turn, that turn's /invoke record stays pending forever.
• LangGraph engine gaps: it has no knowledge-base dispatch, and a chat device-flow link resume parks. The affected specs now run only on Temporal, with the reason recorded next to each gate.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Q4FyzpR8xiataUPf68J4qs