chore(i18n, mdx): adopt strict MDX syntax and remove the transitional shims - #4717
Open
thetaPC wants to merge 1 commit into
Open
chore(i18n, mdx): adopt strict MDX syntax and remove the transitional shims#4717thetaPC wants to merge 1 commit into
thetaPC wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
approved these changes
Sep 9, 2026
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Looks good as long as this gets the contributing guide update too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: internal
What is the current behavior?
Two transitional shims in
plugins/docusaurus-plugin-ionic-component-apiare still carrying the.mdto.mdxrename: the component API plugin emits every partial twice, and anextensionAliaslets any.mdimport resolve to a.mdxfile.The items in Docusaurus 3.10's Strict MDX guidance are also outstanding, so
future.v4.mdx1CompatDisabledByDefaultcannot be turned on. Turning it on today fails the build:What is the new behavior?
The jp companion to #4716. Both shims are gone, and the Strict MDX items are done:
docs/updating/9-0.mdx,{#id}to{/* #id */}{/* */}, in archived v5 and v6:::tip[Title], in archived v6A further 9 commented-out blocks were deleted rather than converted, matching #4716. Each is a placeholder that v7 onward already dropped and nothing else references: an
--item-detail-push-showTODO, fourTOC goes here, twoTODO: image?, and a stubbed## Customization.That clears the last blocker on the v4 flag, which is deliberately not in this PR.
Does this introduce a breaking change?
Other information
This branch needed one fix that main did not. The plugin was still emitting classic heading IDs into every generated partial,
### dismiss {#method-dismiss}, where main had already moved to{/* #method-dismiss */}. That is a Strict MDX violation in generated output rather than in any source file, so no audit of the repo would surface it. It broke 544 generated partials under the flag until the two template lines were updated. Anchors are unchanged: all 359 api pages across v5 to v8 produce identical anchor lists before and after.How to test
Archived versions are the risk here, since 44 of the 48 files are in v5 and v6, so verify them with the flag on:
versions.jsonto["v8", "v7", "v6", "v5"]mdx1CompatDisabledByDefault: trueunderfuture.v4indocusaurus.config.jsnpx docusaurus clear(clearing only.docusaurusleaves the rspack cache, which replays the previous compile and reports a false green)npm run buildAll four versions build: 460 v5, 307 v6, 310 v7, 326 v8, with 852 warnings, the same set as before this change.