fix(segment): expose tab position metadata - #31431
Open
Mahesh5R wants to merge 1 commit into
Open
Conversation
|
@Mahesh5R is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31282
What is the current behavior?
Screen readers may not correctly announce the position and total count of
ion-segment-buttontabs.The native elements with
role="tab"are rendered within each segmentbutton's Shadow DOM, so assistive technologies may not reliably infer the
position of each tab within the segment.
What is the new behavior?
ion-segmentnow calculates the position and total number of its segmentbuttons and provides that information to each
ion-segment-button.The native button with
role="tab"now exposes:aria-posinsetaria-setsizeThe values are recalculated when segment buttons are dynamically added or
removed.
Does this introduce a breaking change?
Other information
Added regression tests covering:
The existing Shadow DOM structure is unchanged.
Validation completed successfully: