Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rumple now takes a point array and voxel resolution and returns a raster and extent on the same XY grid as canopy cover, PAI, and FHD. Each cell measures the canopy surface using its eight neighbors. Missing neighborhoods stay NoData.
Adds tiled GeoTIFF output through
metric="rumple", updated docs, and a notebook example with the resulting map. The tests cover the area calculation, grid alignment, missing data, and matching values across tile boundaries.Also updates the PDAL pin so CI keeps the installed 3.5.x bindings instead of downgrading to 3.4.5.
Validation: 129 tests passed, with one existing slow integration test skipped. GitHub Actions passes on Python 3.11, 3.12, and 3.13. The notebook ran end to end on the bundled LiDAR data and wrote a 1 m rumple GeoTIFF.
This overlaps #54, which uses a different calculation. This version builds the canopy surface from column maxima and uses the Jenness surface-area method.