Skip to content

test: Take the state test sender from secretKey when not given - #1739

Open
zexoverz wants to merge 2 commits into
ipsilon:masterfrom
zexoverz:statetest-secretkey-sender
Open

zexoverz wants to merge 2 commits into
ipsilon:masterfrom
zexoverz:statetest-secretkey-sender

Conversation

@zexoverz

Copy link
Copy Markdown
Contributor

Fixes #1490. A state test transaction without sender now runs from the address of its secretKey, derived with the secp256k1 code already in precompiles. sender still wins when both are given, which is what go-ethereum's toMessage does, and a key outside [1, N) is rejected. Only the GeneralStateTest loader changes, so the t8n path that #1711 reworks is untouched. The issue's fixture is added as a runner test with geth's state root, and it fails on master with INSUFFICIENT_ACCOUNT_FUNDS.

@codspeed

codspeed Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 4.56%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 18 regressed benchmarks
✅ 880 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ test_auth_transaction[fork_Osaka-blockchain_test-zero_delegation_True-empty_authority_True-benchmark-gas-value_1M] 47.9 ms 55.1 ms -13.07%
❌ test_auth_transaction[fork_Osaka-blockchain_test-zero_delegation_True-empty_authority_False-benchmark-gas-value_1M] 48.2 ms 55.4 ms -13%
❌ test_auth_transaction[fork_Osaka-blockchain_test-zero_delegation_False-empty_authority_True-benchmark-gas-value_1M] 49.9 ms 57.1 ms -12.58%
❌ test_auth_transaction[fork_Osaka-blockchain_test-zero_delegation_False-empty_authority_False-benchmark-gas-value_1M] 50.2 ms 57.4 ms -12.55%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_True-SSTORE same value, out of gas-benchmark-gas-value_1M] 4.7 ms 4.9 ms -3.76%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_True-SSTORE new value, out of gas-benchmark-gas-value_1M] 4.7 ms 4.9 ms -3.76%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_True-SSTORE same value, revert-benchmark-gas-value_1M] 4.7 ms 4.9 ms -3.75%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_True-SSTORE new value, revert-benchmark-gas-value_1M] 4.7 ms 4.9 ms -3.65%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_True-SSLOAD-benchmark-gas-value_1M] 5.4 ms 5.6 ms -3.23%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_True-SSTORE new value-benchmark-gas-value_1M] 6.1 ms 6.3 ms -2.91%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_True-SSTORE same value-benchmark-gas-value_1M] 6.1 ms 6.2 ms -2.86%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_False-SSTORE new value, out of gas-benchmark-gas-value_1M] 15.6 ms 15.9 ms -2.32%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_False-SSTORE new value, revert-benchmark-gas-value_1M] 15.5 ms 15.9 ms -2.32%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_False-SSTORE new value-benchmark-gas-value_1M] 15.9 ms 16.2 ms -2.24%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_False-SSTORE same value-benchmark-gas-value_1M] 27.6 ms 27.9 ms -1.33%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_False-SSTORE same value, out of gas-benchmark-gas-value_1M] 27.6 ms 27.9 ms -1.31%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_False-SSTORE same value, revert-benchmark-gas-value_1M] 27.6 ms 27.9 ms -1.31%
❌ test_storage_access_cold[fork_Osaka-blockchain_test-absent_slots_False-SSLOAD-benchmark-gas-value_1M] 28.4 ms 28.8 ms -1.28%
⚡ baseline/analyse/main/sha1_shifts 11.5 µs 11.2 µs +2.71%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing zexoverz:statetest-secretkey-sender (f340a1d) with master (d9e925a)

Open in CodSpeed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

statetest: transaction.secretKey is ignored unless sender is provided

1 participant