state: Pass the transaction to process_authorization_list() - #1741
Conversation
It takes the chain id and the authorization list from the transaction. EIP-2780 needs its sender, recipient and value there too.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1741 +/- ##
==========================================
- Coverage 97.98% 97.98% -0.01%
==========================================
Files 183 183
Lines 16856 16855 -1
Branches 3856 3856
==========================================
- Hits 16516 16515 -1
Misses 250 250
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 2.71%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | baseline/analyse/main/sha1_shifts |
11.5 µs | 11.2 µs | +2.71% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing state/authlist-takes-tx (e31d411) with master (d9e925a)
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused refactor preserves existing behavior and updates its sole caller consistently.
Review effort: Balanced
Findings: None
What changed in this PR
Refactors authorization processing to receive the complete transaction, enabling future EIP-2780 logic without changing current behavior.
Changes:
- Passes
Transactiondirectly toprocess_authorization_list(). - Reads chain ID and authorizations from the transaction.
| File | Description |
|---|---|
test/state/state.cpp |
Updates authorization processing interface and caller. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
It takes the chain id and the authorization list from the transaction. EIP-2780 needs its sender, recipient and value there too.
Peeled from #1733.
🤖 Generated with Claude Code