Skip to content

state: Pass the transaction to process_authorization_list() - #1741

Merged
chfast merged 1 commit into
masterfrom
state/authlist-takes-tx
Sep 28, 2026
Merged

chfast merged 1 commit into
masterfrom
state/authlist-takes-tx

Conversation

@chfast

@chfast chfast commented Sep 27, 2026

Copy link
Copy Markdown
Member

It takes the chain id and the authorization list from the transaction. EIP-2780 needs its sender, recipient and value there too.

Peeled from #1733.

🤖 Generated with Claude Code

It takes the chain id and the authorization list from the transaction.
EIP-2780 needs its sender, recipient and value there too.
@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.98%. Comparing base (d9e925a) to head (e31d411).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1741      +/-   ##
==========================================
- Coverage   97.98%   97.98%   -0.01%     
==========================================
  Files         183      183              
  Lines       16856    16855       -1     
  Branches     3856     3856              
==========================================
- Hits        16516    16515       -1     
  Misses        250      250              
  Partials       90       90              
Flag Coverage Δ
eest-develop 81.76% <100.00%> (-0.01%) ⬇️
eest-develop-gmp 25.87% <100.00%> (-0.01%) ⬇️
eest-legacy 17.10% <33.33%> (-0.01%) ⬇️
eest-libsecp256k1 28.07% <100.00%> (-0.01%) ⬇️
eest-stable 81.76% <100.00%> (-0.01%) ⬇️
evmone-unittests 94.41% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 95.94% <100.00%> (-0.01%) ⬇️
tooling 94.29% <ø> (ø)
tests 99.81% <ø> (ø)
Files with missing lines Coverage Δ
test/state/state.cpp 98.65% <100.00%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will improve performance by 2.71%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 898 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ baseline/analyse/main/sha1_shifts 11.5 µs 11.2 µs +2.71%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing state/authlist-takes-tx (e31d411) with master (d9e925a)

Open in CodSpeed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused refactor preserves existing behavior and updates its sole caller consistently.

Review effort: Balanced
Findings: None

What changed in this PR

Refactors authorization processing to receive the complete transaction, enabling future EIP-2780 logic without changing current behavior.

Changes:

  • Passes Transaction directly to process_authorization_list().
  • Reads chain ID and authorizations from the transaction.
File Description
test/​state/​state.cpp Updates authorization processing interface and caller.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@chfast
chfast merged commit 6aebdeb into master Sep 28, 2026
30 of 31 checks passed
@chfast
chfast deleted the state/authlist-takes-tx branch September 28, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants