test: Express the capped refund expectations as fractions of the gas - #1742
Merged
Merged
Conversation
State the EIP-3529 cap as a fifth of the pre-refund gas instead of the precomputed numbers, so the expectations follow changes of the intrinsic gas.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1742 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 183 183
Lines 16856 16857 +1
Branches 3856 3856
=======================================
+ Hits 16516 16517 +1
Misses 250 250
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Merging this PR will improve performance by 2.71%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | baseline/analyse/main/sha1_shifts |
11.5 µs | 11.2 µs | +2.71% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing test/refund-cap-invariants (2a34b58) with master (d9e925a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
State the EIP-3529 cap as a fifth of the pre-refund gas instead of the precomputed numbers, so the expectations follow changes of the intrinsic gas.
Peeled from #1733.
🤖 Generated with Claude Code