Repository navigation
parse richInspectVariables result with ast.literal_eval - #1572
Open
Keshava-kesh wants to merge 1 commit into
Open
Keshava-kesh wants to merge 1 commit into
Keshava-kesh wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the kernel is stopped on a breakpoint, richInspectVariables asks debugpy to evaluate display_formatter.format on the variable and gets the answer back as a string, the repr of a (data, metadata) tuple. That string is then handed to eval to turn it back into two dicts. The bundle values are whatever the object's formatters returned, so any value whose repr is not a plain literal gets executed as an expression a second time, in the control thread, instead of being read as data. A repr_mimebundle that returns an object with a repr of len('abc') comes back from the handler as 3. I ran into it reading through the debug handlers. Parsing the result with ast.literal_eval keeps the normal case identical and leaves the representation empty when the string is not a literal, the same way the non-breakpoint branch does when user_expressions fails. The change stays inside richInspectVariables, with a regression test next to the existing breakpoint one.