Make Set trait generic - #986
GruffElixir wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The project tests, lint, Codecov, and downstream ipython/ipywidgets/nbconvert/notebook checks are passing. The two remaining failures appear external or transient: Read the Docs stopped during checkout with "fatal: reference is not a tree: b16490a", and the jupyter_server downstream job had one kernel-cull timing failure after 1,153 passes. Could a maintainer rerun those checks when convenient? |
|
The two red checks are environmental rather than Set typing failures: Read the Docs could not resolve the fork head SHA ( |
Fixes #927
Make Set preserve its element type parameter, matching List and the other container traits. This enables annotations such as values: Set[str] = Set() to expose Set[str] on the class and set[str] on instances.
Tests: python -m pytest tests/test_typing.py -q