-
Notifications
You must be signed in to change notification settings - Fork 74
[#827] Add README text on usage of iRODSSession instances #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
d-w-moore
wants to merge
6
commits into
irods:main
Choose a base branch
from
d-w-moore:827.m
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8bbf70c
README section for iRODSSession instance usage
d-w-moore 92f3da2
beef up explanation, and don't present make_session as the 'main' choice
d-w-moore 60166e3
fixes to README
d-w-moore 39d592f
fix order of mention for methods of iRODSSession construction
d-w-moore 210502f
rewording, hopefully for the better
d-w-moore 12a42dd
Update README.md
d-w-moore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -41,7 +41,62 @@ Uninstalling | |||||
| Establishing a (secure) connection | ||||||
| ---------------------------------- | ||||||
|
|
||||||
| One way of starting a session is to pass iRODS credentials as keyword | ||||||
| An `iRODSSession` instance is the interface object through which iRODS server | ||||||
| APIs can be invoked. One can create the object using constructor form directly, | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| passing connection and authentication options within the call parameter list: | ||||||
|
|
||||||
| ```python | ||||||
| >>> from irods.session import iRODSSession | ||||||
| >>> with iRODSSession(host='localhost', port=1247, user='bob', password='1234', zone='tempZone') as session: | ||||||
| ... # Any number of operations using the 'session' variable can go here. | ||||||
| ``` | ||||||
|
|
||||||
| Another way to create the session object, assuming one has already successfully | ||||||
| set up a client environment via `iinit`, is by using the convenience function `make_session`: | ||||||
|
|
||||||
| ```python | ||||||
| >>> from irods.helpers import make_session | ||||||
| >>> session = make_session() | ||||||
| ``` | ||||||
|
|
||||||
| Once created, the `iRODSSession` instance can be managed from a choice between two | ||||||
| possible patterns. Firstly, one can allow references to the instance to persist as | ||||||
| is natural for the application. This allows Python interpreter's reference counting to | ||||||
| let the object pass out of scope and destroy the underlying server connection(s) at the | ||||||
| proper time: | ||||||
|
|
||||||
| ```python | ||||||
| home_coll = session.collections.get(f'/tempZone/home/{session.username}') | ||||||
| # (... Further instances of calls to the server through 'session' may follow.) | ||||||
| ``` | ||||||
|
Comment on lines
+62
to
+71
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The code block on line 68 seems out of place in relation to the text on line 62. Feels like the code block can be removed entirely? |
||||||
|
|
||||||
| This casual approach usually ends up being the optimal choice in terms of efficiency, since | ||||||
| connections are expensive to create and destroy, and any given connection to the iRODS | ||||||
| server can be employed consecutively and for disparate purposes without incident. | ||||||
|
|
||||||
| Alternatively a context manager may be used, thus forcing connections to be | ||||||
| provisionally cleared from the session object once a given block of code has | ||||||
| executed: | ||||||
|
|
||||||
| ```python | ||||||
| with make_session() as session: | ||||||
| my_user = session.users.get(session.username) | ||||||
| # We can have further usage of 'session' in this code block. At the end | ||||||
| # of it, session.cleanup() is implicitly called to remove any idle connections. | ||||||
| ``` | ||||||
|
|
||||||
| Either way, the instance remains available for further use afterward, until | ||||||
| destructed. | ||||||
|
|
||||||
| We should, of course, be mindful of how many still-connected `iRODSSession` | ||||||
| objects we retain references to in an application, as having more of them than | ||||||
| the system can support database connections for can result in the spurious failure | ||||||
| of new connections. | ||||||
|
|
||||||
| Finer points in connecting to the iRODS server | ||||||
| ---------------------------------------------- | ||||||
|
|
||||||
| iRODS credentials may also be passed as keyword | ||||||
| arguments: | ||||||
|
|
||||||
| ```python | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This title includes
(secure), but SSL/TLS isn't mentioned until the next section.Consider whether
(secure)should be moved or removed?