Repository navigation
Updated drupal core - #136
Merged
Merged
Conversation
rimi-itk
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
Regarding code changes for code analysis to pass:
Note
Replaced cached entity storage properties with EntityTypeManagerInterface + on-demand getStorage() calls.
Caching storage handlers in a property is a known anti-pattern in Drupal — they can go stale when storage
is rebuilt/swapped, and don't serialize safely. See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal
Note
The remaining checks fail due to chx/drupal-issue-fork no longer existing and the action attempts to build from the old code base