Add tests for YAML 1.2 specification examples by alex-thiessen-for-siemens · Pull Request #1493 · jbeder/yaml-cpp

alex-thiessen-for-siemens · 2026-09-08T09:34:34Z

Summary

Add node and event-handler coverage for the remaining YAML 1.2 specification examples.
Extend the shared specification fixtures used by the integration tests.
Keep the coverage organized by specification example so each case is traceable to the YAML 1.2 text.

Testing

CMake/CTest suite passes with 1,110 tests.

Closes #38

Correct the expected trailing line breaks for Examples 8.5 and 8.21 in both specification test layers. These parser results already match the YAML 1.2.2 examples, so the tests no longer need to be disabled. Reference verification: not applicable. This contribution records YAML 1.2 specification examples. No external semantic oracle is required.

Cover Example 2.19 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 2.20 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 2.21 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 2.22 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 5.1 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 5.1 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 5.2 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 5.2 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 5.9 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 5.9 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 5.10 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 5.10 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 9.1 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 9.1 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 9.2 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 9.2 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 9.3 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 9.3 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 9.4 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 9.4 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 9.5 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 9.5 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 9.6 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 9.6 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.1 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.1 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.2 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.2 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.3 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.3 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.4 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.4 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.5 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.5 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.6 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.6 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.7 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.7 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.8 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.8 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.9 in the event-handler specification test suite and introduce its canonical YAML fixture. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Cover Example 10.9 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

SGSSGene

Thank your for this PR, this is highly appriciated.

To get a better grip on all the changes I added ':+1:` everypart that I agree with.

I did found a few things, to make them find them easier, a list them here explicitly:

Waiting for resolution of Ex8_21_BlockScalarNodes (or we put a SPEC GAP marker here or similar)
ex9_1 is not correct
Unclear if DISABLED_Ex10_8_JsonTagResolution test is correct
TEST_F(NodeSpecTest, Ex10_1_MapExamples) not testing everything
TEST(NodeSpecTest, Ex10_2_SequenceExamples) not testing everything

SGSSGene · 2026-10-07T08:04:45Z

 }

-// TODO: 5.1 - 5.2 BOM
+TEST_F(HandlerSpecTest, Ex5_1_ByteOrderMark) { Parse(ex5_1); }


👍 (I will mark every test that I have checked, to keep an overview)

SGSSGene · 2026-10-07T08:04:54Z

+TEST_F(HandlerSpecTest, Ex5_1_ByteOrderMark) { Parse(ex5_1); }
+
+TEST_F(HandlerSpecTest, Ex5_2_InvalidByteOrderMark) {
+  EXPECT_THROW(IgnoreParse(ex5_2), ParserException);


SGSSGene · 2026-10-07T08:06:43Z

+const char *ex5_9 =
+    "%YAML 1.2\n"
+    "--- text";
+
+const char *ex5_10 =
+    "commercial-at: @text\n"
+    "grave-accent: `text";


SGSSGene · 2026-10-07T08:06:50Z

+const char *ex5_1 =
+    "\xEF\xBB\xBF"
+    "# Comment only.";
+
+const char *ex5_2 =
+    "- Invalid use of BOM\n"
+    "\xEF\xBB\xBF"
+    "- Inside a document.";


SGSSGene · 2026-10-07T08:07:38Z

+TEST_F(HandlerSpecTest, Ex5_9_DirectiveIndicator) {
+  EXPECT_CALL(handler, OnDocumentStart(_));
+  EXPECT_CALL(handler, OnScalar(_, "?", 0, "text"));
+  EXPECT_CALL(handler, OnDocumentEnd());
+  Parse(ex5_9);
+}


SGSSGene · 2026-10-07T09:10:43Z

+TEST(NodeSpecTest, Ex10_5_BooleanExamples) {
+  Node doc = Load(ex10_5);
+  EXPECT_TRUE(doc["YAML is a superset of JSON"].as<bool>());
+  EXPECT_FALSE(doc["Pluto is a planet"].as<bool>());
+}
+


SGSSGene · 2026-10-07T09:10:56Z

+TEST(NodeSpecTest, Ex10_6_IntegerExamples) {
+  Node doc = Load(ex10_6);
+  EXPECT_EQ(-12, doc["negative"].as<int>());
+  EXPECT_EQ(0, doc["zero"].as<int>());
+  EXPECT_EQ(34, doc["positive"].as<int>());
+}


SGSSGene · 2026-10-07T09:11:23Z

+TEST(NodeSpecTest, Ex10_7_FloatingPointExamples) {
+  Node doc = Load(ex10_7);
+  EXPECT_DOUBLE_EQ(-1.0, doc["negative"].as<double>());
+  EXPECT_DOUBLE_EQ(0.0, doc["zero"].as<double>());
+  EXPECT_DOUBLE_EQ(23000.0, doc["positive"].as<double>());
+  EXPECT_TRUE(std::isinf(doc["infinity"].as<double>()));
+  EXPECT_GT(doc["infinity"].as<double>(), 0.0);
+  EXPECT_TRUE(std::isnan(doc["not a number"].as<double>()));
+}


SGSSGene · 2026-10-07T09:12:40Z

+
+TEST(NodeSpecTest, DISABLED_Ex10_8_JsonTagResolution) {
+  // SPEC_GAP: yaml-cpp uses the YAML 1.1-compatible resolver for several
+  // values that YAML 1.2 JSON resolution leaves as strings.


The only real issue here is IsNull isn't it?

because as<bool> could just be as<std::string> as well.

SGSSGene · 2026-10-07T09:12:52Z

+const char *ex5_1 =
+    "\xEF\xBB\xBF"
+    "# Comment only.";
+


alex-thiessen-for-siemens force-pushed the yaml12-spec-examples branch from 53ad40e to fc28fcd Compare September 8, 2026 09:49

alex-thiessen-for-siemens marked this pull request as ready for review September 8, 2026 10:05

SGSSGene requested changes Sep 8, 2026

View reviewed changes

Comment thread test/integration/handler_spec_test.cpp

alex-thiessen-for-siemens force-pushed the yaml12-spec-examples branch from fc28fcd to a80652e Compare September 8, 2026 13:58

alex-thiessen-for-siemens requested a review from SGSSGene September 9, 2026 15:32

alex-thiessen-for-siemens added 25 commits September 20, 2026 12:24

Add node test for YAML 1.2 Example 2.19

9b75d05

Cover Example 2.19 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 2.20

a888fe7

Cover Example 2.20 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 2.21

e4b15af

Cover Example 2.21 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 2.22

f1a1eaf

Cover Example 2.22 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 5.1

4b4fb01

Cover Example 5.1 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 5.2

4a5af30

Cover Example 5.2 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 5.9

6a49dca

Cover Example 5.9 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 5.10

1c0e565

Cover Example 5.10 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 9.1

18740f8

Cover Example 9.1 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 9.2

b1605ca

Cover Example 9.2 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 9.3

9527472

Cover Example 9.3 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 9.4

51a29bd

Cover Example 9.4 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 9.5

e60d7df

Cover Example 9.5 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 9.6

03e12a9

Cover Example 9.6 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

alex-thiessen-for-siemens added 18 commits September 20, 2026 12:24

Add node test for YAML 1.2 Example 10.1

56f0fd1

Cover Example 10.1 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 10.2

cee5900

Cover Example 10.2 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 10.3

f288035

Cover Example 10.3 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 10.4

64a89f9

Cover Example 10.4 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 10.5

079f550

Cover Example 10.5 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 10.6

ecd70c3

Cover Example 10.6 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 10.7

46a2b4c

Cover Example 10.7 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 10.8

108a385

Cover Example 10.8 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

Add node test for YAML 1.2 Example 10.9

b259845

Cover Example 10.9 in the node specification test suite. Reference verification: not applicable - this contribution records YAML 1.2 specification examples; no external semantic oracle is required.

alex-thiessen-for-siemens force-pushed the yaml12-spec-examples branch from a80652e to b259845 Compare September 20, 2026 10:27

SGSSGene reviewed Oct 7, 2026

View reviewed changes

Navigation Menu

Repository navigation

Add tests for YAML 1.2 specification examples - #1493

Add tests for YAML 1.2 specification examples#1493
alex-thiessen-for-siemens wants to merge 43 commits into
jbeder:masterfrom
alex-thiessen-for-siemens:yaml12-spec-examples

alex-thiessen-for-siemens commented Sep 8, 2026

Uh oh!

Uh oh!

SGSSGene left a comment

Uh oh!

SGSSGene Oct 7, 2026

Uh oh!

SGSSGene Oct 7, 2026

Uh oh!

SGSSGene Oct 7, 2026

Uh oh!

SGSSGene Oct 7, 2026

Uh oh!

SGSSGene Oct 7, 2026

Uh oh!

SGSSGene Oct 7, 2026

Uh oh!

SGSSGene Oct 7, 2026

Uh oh!

SGSSGene Oct 7, 2026

Uh oh!

SGSSGene Oct 7, 2026

Uh oh!

SGSSGene Oct 7, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

alex-thiessen-for-siemens commented Sep 8, 2026

Summary

Testing

Uh oh!

Uh oh!

SGSSGene left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants