Conversation
This was referenced Sep 22, 2026
`ColumnMetaOf` reads the meta a declared list states, because such a list is a plain array with no tuple members to read. `CellArgsOf` has no such branch, so it always goes back to the Cells, and a list whose args are a type parameter has no Cell to read them from. A component that takes a column list from its caller and builds the table itself could therefore not keep the args of that list. The args now come from the config, the way the row type already does. A list written in place still reads its Cells. Cowritten by Claude
johanrd
force-pushed
the
cell-args-of-array
branch
from
September 22, 2026 23:17
7749402 to
b7a2273
Compare
NullVoxPopuli
approved these changes
Sep 23, 2026
Owner
Author
|
superseded by universal-ember#203 |
NullVoxPopuli
added a commit
to universal-ember/table
that referenced
this pull request
Sep 23, 2026
…red lists - A column list with a declared type keeps its cell args, like it keeps its column meta. A shared component that takes `ColumnConfig<Row, unknown, unknown, CellArgs>[]` from its caller can build the table (johanrd#6). - Each column written in place is checked on its own: its Cell takes the row type, the column's meta and the table meta, and when the Cell asks for `@options`, the column's `options` returns them. - A table `meta` together with a callback that has parameters no longer loses the inferred cell args and column meta. The Cell check read the column list while TypeScript was still inferring it. - `CellOptions` and `CellOptionsOf` are exported (johanrd#5). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of universal-ember#202 (cfbb714). Independent of #4 and #5.
ColumnMetaOfhas a branch for a column list that is a plain array — "A list with a declared type keeps that type".CellArgsOfhas no such branch: it always derives the args from the Cells of the list. A plain array has no Cells to read, so the args are lost.This stops a shared table component, which takes a column list from its caller and builds the table itself:
The args now come from the config through a type-only property, the way the row type already does. A list written in place still reads its Cells, so nothing that infers today changes.
generic-wrapper.test.tscovers it. The package, its type tests andtest-appare clean.Cowritten by Claude