Skip to content

fix(core): remove unused g_windowDpi variable - #261

Merged
justnullname merged 1 commit into
justnullname:devfrom
cmixed:dev
Sep 19, 2026
Merged

justnullname merged 1 commit into
justnullname:devfrom
cmixed:dev

Conversation

@cmixed

@cmixed cmixed commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

g_windowDpi was assigned in RefreshWindowDpi() but never read anywhere. The actual DPI scaling is driven by g_uiScale via ApplyUIScale(), making g_windowDpi dead code since its introduction in d93f544.

part of information in bash :

main.cpp(584,13): error: variable 'g_windowDpi' set but not used [-Werror,-Wunused-but-set-global]
  584 | static UINT g_windowDpi = USER_DEFAULT_SCREEN_DPI;
      |             ^
1 error generated.

QuickView> cmake --build out/build/Release-LTO
[2/2] Linking CXX executable QuickView.exe

@justnullname
justnullname merged commit efe01df into justnullname:dev Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants