Repository navigation
fix(tree-compare): label previous commit and branch head buttons - #2157
Open
alanpeixinho wants to merge 1 commit into
Open
alanpeixinho wants to merge 1 commit into
alanpeixinho wants to merge 1 commit into
Conversation
Contributor
Author
|
We included a label to indicate action, and also a tooltip to show, to which commit we are moving into. |
* Show Previous commit and Branch head as text labels on the buttons * Show the destination commit in a tooltip: hash, name, tags, and date * Use one destination lookup for the tooltip and the click Closes kernelci#2128 Assisted-by: Grok 4.7 <noreply@x.ai> Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
alanpeixinho
force-pushed
the
fix/tree-compare/revision-button-labels
branch
from
October 6, 2026 18:46
d71fa16 to
215bef0
Compare
Member
|
out of context, but this is also a good place to apply the commit history we will ingest. |
felipebergamin
approved these changes
Oct 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it is
Previous commit and Branch head were icon buttons. They now show those labels. Hovering a button shows the commit it selects: short hash, name, tags, and date. The tooltip and the click use the same destination lookup.
Closes #2128
How to test
Open a tree compare page that has at least two revisions. Both buttons should read "Previous commit" and "Branch head". Hover each one and check that the tooltip names the commit the click selects. Click Previous commit and that side should move to the older revision. Click Branch head and it should move to the newest revision.
Made with Cursor