Repository navigation
fix(cli): expose MCP configuration diagnostics in doctor - #189
Merged
Merged
Conversation
Owner
Author
|
/pkg-pr-new |
Contributor
|
pkg-pr-new preview for commit npx --yes https://pkg.pr.new/zcode-app-cli@e254fbbThis preview uses the selected commit. PR updates publish automatically after CI succeeds; kingsword09 can also request a preview with |
Preserve the doctor routing regression test and the platform-specific OAuth test description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zcode doctorpreviously showed runtime metadata without configuration diagnostics, and the launcher could reject broken settings before doctor ran. For example, a valid JSON file containingui.theme: "system"can cause the runtime to ignore the user settings and omit its custom MCP servers.This change makes that failure inspectable:
configurationreport.setting.jsonas this package's MCP configuration file, the separate provider schema, native MCP precedence, migration behavior, and upstream/Desktop path differences.The report covers user/project configuration; plugin and built-in MCP servers are added at session startup. It does not test connectivity. MCP discovery and merge behavior remain unchanged.
Related to #188. This improves diagnosis of the reported symptom; the original reporter's environment-specific root cause is still unconfirmed.
Validation completed locally on macOS arm64:
bun run typecheckbun run test:unit— 753 passedbun test test/runtime/config-diagnostics.test.ts test/runtime/config-migration.test.ts test/runtime/launcher.test.ts— 15 passedbun scripts/check-runtime.tsresolve-library-idandquery-docs.