fix(draft-release-announcement.sh): address feedback from PR #281 - #286
Merged
Merged
Conversation
- Default author name to git config user.name - Default GitHub handle to gh api user login (without @) - Default new tag prompt to main for gh api compare compatibility - Remove redundant H1 heading in generated post Assisted-by: mlx-coders/Qwen3.5-9B-oQ8-fp16-mtp Signed-off-by: Sam Barker <sam@quadrocket.co.uk>
robobario
approved these changes
Sep 7, 2026
robobario
left a comment
robobario
left a comment
Member
There was a problem hiding this comment.
LGTM, should we ref the new script in the README/CLAUDE guide? Or just from the RELEASING.md in the other repo?
robobario
reviewed
Sep 7, 2026
- Prompt user for release tagline (key features/themes) - Default value: 'sasl termination, filter api changes' - Use tagline in generated H1 heading Assisted-by: mlx-coders/Qwen3.5-9B-oQ8-fp16-mtp Signed-off-by: Sam Barker <sam@quadrocket.co.uk>
…eading - Tagline now rendered as # heading (paragraph level) - Preserve existing template structure with TODO sections - Remove blank line before Community Contributions Assisted-by: mlx-coders/Qwen3.5-9B-oQ8-fp16-mtp Signed-off-by: Sam Barker <sam@quadrocket.co.uk>
SamBarker
commented
Sep 7, 2026
|
|
||
| # ── write post ──────────────────────────────────────────────────────────────── | ||
|
|
||
| cat > "$FILENAME" <<EOF |
Member
Author
There was a problem hiding this comment.
I'm not entirely sold by having this as here doc in bash script but I think its good enough for now.
Signed-off-by: Sam Barker <sam@quadrocket.co.uk>
robobario
reviewed
Sep 7, 2026
Signed-off-by: Sam Barker <sam@quadrocket.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #281
Changes
Author defaults: Now pre-fills with local git config and GitHub user info
New tag prompt: Defaults to instead of empty, enabling {
"message": "Not Found",
"documentation_url": "https://docs.github.com/rest",
"status": "404"
} to work with latest commits
Removed redundant H1: Eliminated the line to avoid duplicate H1 headings in blog list
The defaults make the workflow smoother while still allowing overrides.