Test against real Lambda Feedback exports - #41
Open
peterbjohnson wants to merge 2 commits into
Open
peterbjohnson wants to merge 2 commits into
peterbjohnson wants to merge 2 commits into
Conversation
m-messer
requested changes
Sep 16, 2026
m-messer
left a comment
Member
There was a problem hiding this comment.
The filter refactor is a great change.
Testing an exported version of a set from LF is a great idea, but I think it is the wrong implementation. If the LF import schema changes, the test code won't detect it, and all test documents will become stale and need to be regenerated. A more complex but more robust approach would be to provide a file to in2lambda, send it to staging or some specific test environment, and then export the set to validate the entire end-to-end pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in2lambda writes files for Lambda Feedback to import, but nothing checks its output against what Lambda Feedback actually produces. We have a real exported question set, and we will accumulate many more; adding one to the test data should never require changing code.
Done when a real export is part of the test data, the suite loads it, writes it back and compares, and dropping another export beside it is picked up on its own. The filter tests need the same treatment: they name each filter by hand, so a new filter is covered only if someone remembers.
The first real export is already on main in tests/fixtures/exports/, with a README describing the export's JSON. Those files are exactly as Lambda Feedback wrote them and must stay that way.
Workbench ticket t19.