Skip to content

LDClient#*VariationDetail returns null EvaluationReason with r8 enabled #273

Description

@tevjef

Describe the bug
LDClient#*VariationDetail returns null EvaluationReason with r8 enabled

Expected behavior
I expect the EvaluationReason to never be null on both debug and release builds of our app.

Logs

Logging the detail and reason on release builds shows the value is null.

image

SDK version
5.3.0

Language version, developer tools

AGP 8.4.x with r8 full mode is enabled.

Activity

  1. tanderson-ld commented on Jun 28, 2024

    @tanderson-ld
    Contributor

    HI @tevjef, thank you for reporting this. I believe this issue that is open is a semi-match and the workaround in it could potentially work for you. We have also filed an issue internally for R8 and will get to it when priorities allow. Please let me know if the workaround in that other issue works for you.

  2. tevjef commented on Jul 2, 2024

    @tevjef
    Author

    @tanderson-ld Hey, adding those rule does not work for me. I see those rules are already part of the consumer-proguard rules.

  3. tanderson-ld commented on Jul 8, 2024

    @tanderson-ld
    Contributor

    Are you able to experiment with excluding all LaunchDarkly classes?

    I have also linked this issue to our internally tracked R8 Ticket, 199469

  4. sgjesse commented on Sep 4, 2024

    @sgjesse

    Maybe stating the obvious here, but as this SDK already has consumer keep rules, they might just have a missing some rule. One thing I noticed was that these rules also have Gson rules included. However, with the release of Gson 2.11.0 I think they can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions