feat(AIC-3363): Support inline datasets - #95
Open
aknight-ld wants to merge 5 commits into
Open
aknight-ld wants to merge 5 commits into
aknight-ld wants to merge 5 commits into
Conversation
aknight-ld
marked this pull request as ready for review
September 18, 2026 18:58
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6748eaa. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Server side support of inline datasets is in flight; this PR covers the corresponding SDK work to pass in dataset rows defined from code.
Sizable test suite added in, testing underway to ensure we are matching the server.
Note
Overview
Adds inline datasets so
init_evaluations().run()accepts either a hosteddatasetkey or caller-suppliedrows=[DatasetRow(...)], with exactly one required and no dataset API traffic for inline runs.Inline rows are normalized through shared
_render_row(templates, injectedinput/expected_outputinvariables) without mutating caller objects. Pre-flight validation covers row count (10k), unique non-negativerow_index, JSON-serializablevariables/metadata, and rendered UTF-8 byte limits (1 MiB per field) so bad payloads fail before generation or silent event loss.Generation events for inline runs omit
datasetId/datasetKey(five-fieldeventId) and include rowinput,expectedOutput,variables, andmetadata; hosted runs keep excluding row bodies. Run creation sends{"source": "api"}withoutdatasetIdwhen inline. Criterion payloads treat dataset identifiers as optional.Docs in
packages/aiandpackages/clientREADMEs plusagents.mddescribe the new mode and pitfalls. A largetest_evaluations_run.pysuite covers API shapes, events, rendering, limits, and validation errors.Reviewed by Cursor Bugbot for commit d9971cd. Bugbot is set up for automated code reviews on this repo. Configure here.