Skip to content

docs: remove the internal staging host from a public repo - #96

Open
donei003 wants to merge 1 commit into
mainfrom
docs/remove-internal-staging-host
Open

donei003 wants to merge 1 commit into
mainfrom
docs/remove-internal-staging-host

Conversation

@donei003

@donei003 donei003 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

ld-stg.launchdarkly.com appeared in four places in this public repository. Spotted in the diff of #89, but present on main independently of it and in three files that PR does not touch — so it is fixed here, on its own, rather than gated behind a feature branch.

File Was
packages/ai/README.md "LD_UI_BASE_URI (for example, https://ld-stg.launchdarkly.com in staging)"
packages/client/README.md env var table: "staging: https://ld-stg.launchdarkly.com"
packages/client/tests/test_evaluations.py ×2 the host as a test fixture value

Change

The READMEs now say what the option is for, without naming a host. That is the part a reader actually needs — and the part that was missing:

Evaluation-run links use the explicit ui_base_uri option or LD_UI_BASE_URI, defaulting to https://app.launchdarkly.com; set it when the project is not in production, or a run created elsewhere still links to the production app.

Naming LaunchDarkly's own non-production host helped nobody: an external reader cannot reach it, and an internal one does not learn it from an SDK README.

The tests move to ui.staging.example.com, which is the convention the rest of that file already follows — api.staging.example.com, relay.example.com, other.example.com, ui.example.com. ld-stg was the only outlier. It stays distinct from ui.example.com on purpose: that test asserts the explicit option beats the environment variable, which needs two different values to mean anything.

Scope check

Grepped ld-stg, stg.launchdarkly, and launchdarkly-stg across the whole tree — these four were all of them, and the tree is now clean. The sibling ai-sdks-monorepo (internal) and ai-sdk-evaluations-example (private) never mentioned it.

Validation

uv run pytest -q — 1250 passed, 11 skipped. ruff check clean.

Not a draft: it is four lines, self-contained, and the sooner it is off a public main the better.

🤖 Generated with Claude Code


Devin Review


Note

Overview
Removes ld-stg.launchdarkly.com from the public tree and replaces it with guidance that does not name LaunchDarkly’s internal staging app.

README updates in packages/ai/README.md and packages/client/README.md now describe LD_UI_BASE_URI / ui_base_uri as controlling evaluation-run links (default https://app.launchdarkly.com) and say to set it for non-production projects so runs do not still point at the production app—without listing a staging URL.

Tests in test_ui_base_uri_precedence_and_api_base_isolation use https://ui.staging.example.com, matching the file’s existing *.example.com staging fixtures and staying distinct from ui.example.com for the explicit-vs-env precedence assertion.

No runtime or API behavior changes—documentation and test data only.

Reviewed by Cursor Bugbot for commit 00b8dba. Bugbot is set up for automated code reviews on this repo. Configure here.

packages/ai/README.md and packages/client/README.md named
ld-stg.launchdarkly.com as the staging value for LD_UI_BASE_URI, and
test_evaluations.py used it as a fixture. This repository is public, so
that published an internal hostname for no benefit: a reader setting
LD_UI_BASE_URI needs to know the option exists and why, not the name of
LaunchDarkly's own non-production host, which they cannot reach anyway.

Both README entries now say what the option is for -- set it for a
non-production project, or its runs still link to the production app --
without naming a host. The tests move to ui.staging.example.com, which
is the convention the rest of that file already follows
(api.staging.example.com, relay.example.com, other.example.com,
ui.example.com), so ld-stg was the only outlier.

Distinct from ui.example.com on purpose: that test asserts the explicit
option wins over the environment variable, which needs two different
values to mean anything.

Found while reviewing #89, but present on main independently of it and
in three files that PR does not touch, so it is fixed here rather than
inside a feature branch.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants