Skip to content

fix(layouts): stop emitting invalid ids on Markdown images #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamza-mohd merged 1 commit into from
Sep 20, 2026
Merged

fix(layouts): stop emitting invalid ids on Markdown images #1253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions layouts/_default/_markup/render-image.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@
magnific modal popup. Use format ![alt text](/path/to/image.img) -->
<!-- Place this file in layouts > _default > _markup > render-image.html -->
<!-- Also place the image-modal.css and partial/image-modal.html appropriately. -->
<!-- Id for the image on the page is set to a random 6 numbers, chosen from 1 to 500 -->
<!-- Onclick opens the modal, and displays/overlays the the image that has the id for the
clicked image. -->
<!-- The image is passed to openModal directly, so no generated id is needed. The previous
`first 6 (shuffle (seq 1 500))` emitted a whole slice, e.g. id="[487 38 279 330 254 290]",
which is not a valid HTML id. openModal accepts an <img> element as well as an id. -->
<!-- Onclick opens the modal, and displays/overlays the clicked image. -->
<!-- attribution appreciated. github: zjeaton web: https://froglegs.co -->

<div class="md__image">
<img id="{{ first 6 (shuffle (seq 1 500)) }}" src="{{ .Destination | safeURL }}" onclick="openModal(this.id)" alt="{{ .Text }}"
<img src="{{ .Destination | safeURL }}" onclick="openModal(this)" alt="{{ .Text }}"
class="md-image-responsive{{ with .Title }} {{ . }}{{ end }}" />
Comment thread
coderabbitai[bot] marked this conversation as resolved.
</div>
Loading