docs(kanvas): correct three Designer UI descriptions - #1255
Conversation
Verified against the current Kanvas UI (v1.0.70, and the same chrome anonymously on kanvas.new): - The layout control is in the bottom-left corner of the canvas, not in a bottom toolbar beside the zoom controls. The zoom controls are in the opposite corner, bottom-right, where they expand to fit-to-screen, full-screen and zoom. - The dock has no Layers button. Layers opens from the toolbar above the canvas, beside Comments, Actions and Share. - While a change is saving the indicator is a pair of circling arrows, not a cloud with an arrow. The saved state is a cloud with a tick, which was already correct, so the opening line now says "indicator" rather than "cloud icon" to cover both. Signed-off-by: hiyach28 <hiyach28@gmail.com>
|
Warning Review limit reachedNext included review available in 48 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for PR #1255 removed. This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
|
Muse Code review: docs(kanvas) UI-description corrections look correct and internally consistent. Verified against current master: both touched files still carry the old wording (so the PR is not stale or already applied), no other page in What I checked:
One inconsistency the PR introduces (actionable):
Nits (optional, pre-existing):
Caveat: I could not independently verify the live Kanvas UI (v1.0.70 / kanvas.new); this review is based on internal consistency with the repo's own docs and screenshots, which all point in the direction of this PR. Nothing here blocks merging — the caption fix above is the only change I'd suggest, and it can be a follow-up. |
hamza-mohd
left a comment
There was a problem hiding this comment.
I will follow up on the suggested caption change.
Fixes #1267
Three statements in the Designer docs no longer match the product. Each was checked against the current UI (v1.0.70 signed in, and the same chrome signed out on
kanvas.new), not inferred.1. Layout control location
kanvas/designer/layout-and-layersThe layout control is a round button in the bottom-left corner of the canvas. The zoom controls are in the bottom-right corner, where they expand into fit-to-screen, full-screen and zoom. They are not adjacent, and neither sits in the dock. The product's own onboarding callouts point to them separately: "select a layout for your design" to the bottom-left, "fit-to-screen, full-screen, zoom" to the bottom-right.
2. Layers button
kanvas/designer/layout-and-layersThe dock contains selection, components, Kubernetes, shapes, comment, image, text, section, annotation and help tools. There is no Layers button in it. Layers is in the toolbar above the canvas, beside Comments, Actions and Share. The dock is identical signed in and signed out, so this is not a session difference.
3. Save indicator icon
kanvas/designer/saving-designsWhile a save is in flight the indicator is a pair of circling arrows beside the design name. The saved state is a cloud with a tick, which the table already described correctly, so the opening sentence now says "indicator" rather than "cloud icon" to cover both states.