Conversation
Both figures on validating-designs were captured in the older light theme and no longer match Kanvas. Replace them with captures of the current Validate design modal: - successful-validation.png: a clean run, reporting the components and annotations checked and 0 errors. - validation-error.png: a failing run with the component's row expanded, showing its three field-level messages. The example error in the text named a field the old screenshot showed, so it now describes the error in the new one and mentions that the row has to be expanded to see the messages. Signed-off-by: hiyach28 <hiyach28@gmail.com>
|
Warning Review limit reachedNext included review available in 14 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1256/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both figures on
kanvas/tasks/designs/validating-designswere captured in the older light theme and no longer match what Kanvas shows. Replaced with fresh captures of the current Validate design modal, cropped to the modal edges.successful-validation.pngvalidation-error.pngFilenames are unchanged, so no references move.
Text change
The "Missing Required Field" example named the exact field the old screenshot happened to show (
.spec.template.spec.containers.0.env.0). The new capture shows a different component, so the sentence now describes that one, and mentions that a component's row has to be expanded before its messages appear, which the modal does not do by default.Notes