Skip to content

Skip repeated pool rows of a tx in get_pooled_txs. #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Oct 10, 2026
Merged

Skip repeated pool rows of a tx in get_pooled_txs. #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions include/bitcoin/database/impl/query/consensus/consensus_states.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,13 @@ code CLASS::get_pooled_txs(pool_link& cursor, tx_links& out,
const auto stop = std::min(end.value, store_.pool.count().value);
for (; row < stop && out.size() < limit; ++row)
{
// The first row of a tx is its last committed, so this skips both its
// earlier rows and any uncommitted row (its key does not resolve to it).
const tx_link link{ store_.pool.get_key(row) };
if (!is_confirmed_tx(link))
out.push_back(link);
if (store_.pool.first(link) != row || is_confirmed_tx(link))
continue;

out.push_back(link);
}

cursor = row == stop ? end : pool_link{ row };
Expand Down
24 changes: 24 additions & 0 deletions test/query/properties_tx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,30 @@ BOOST_AUTO_TEST_CASE(query_properties_tx__get_pooled_txs__confirmed__skipped)
BOOST_REQUIRE_EQUAL(cursor, 2u);
}

BOOST_AUTO_TEST_CASE(query_properties_tx__get_pooled_txs__duplicate_row__first_only)
{
settings settings{};
settings.path = TEST_DIRECTORY;
test::chunk_store store{ settings };
test::query_accessor query{ store };
BOOST_REQUIRE(!store.create(test::events_handler));
BOOST_REQUIRE(query.initialize(test::genesis));
BOOST_REQUIRE(query.set(test::block1, test::context, {}, false, false));

const auto& in = *test::tx_spend_one_hash.inputs_ptr()->front();
in.prevout = system::to_shared<output>(0x30, script{});
in.metadata.parent_tx = 42;
BOOST_REQUIRE(query.set_pooled(1, test::tx_spend_one_hash, context{ bip113, 8, 9 }));
BOOST_REQUIRE(query.set_pooled(1, test::tx_spend_one_hash, context{ bip113, 8, 9 }));

tx_links out{};
pool_link cursor{};
BOOST_REQUIRE_EQUAL(query.get_pooled_txs(cursor, out, pool_link{ 2 }, max_size_t), error::success);
BOOST_REQUIRE_EQUAL(out.size(), one);
BOOST_REQUIRE_EQUAL(out.front(), 1u);
BOOST_REQUIRE_EQUAL(cursor, 2u);
}

BOOST_AUTO_TEST_CASE(query_properties_tx__get_pooled_txs__limit__resumed)
{
settings settings{};
Expand Down
Loading