ci: fix MSRV tests. make more reliable. - #117
Merged
Merged
Conversation
Help make MSRV CI more reliable. - Migrate edition 2021 -> 2024 - Change resolver v2 -> v3 These two changes together enable the MSRV-aware resolver by default: <https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions>
Reduce the amount of dependency pinning we need to do when building `ldk-node` in the integration tests by using the MSRV-aware resolver.
|
I've assigned @tankyleo as a reviewer! |
tnull
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should make MSRV tests in CI more reliable, with less package pinning required.
First, migrate the workspace to edition 2024 and resolver-v3, so we enable the MSRV-aware resolver by default:
https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
This is stable since 1.84, so shouldn't require an MSRV bump.
Then manually enable the MSRV-aware resolver for
ldk-nodebuild in the integration test. This should reduce the number of pinned packages required to getldk-nodeto build cleanly.Alternative
Add
cargo update -p encoding-rs --precise "0.8.35" --verboseMSRV pin to all CI workflows