Repository navigation
fix: unblock Java releases and replace the stale README - #1
Merged
Merged
Conversation
Every release since 1.144.0 failed at "Build with Maven": the API spec gained an OAuth2 security scheme, so the generated ApiClient and OAuthOkHttpClient import org.apache.oltu.oauth2, but the hand-kept pom.xml (restored over the generated one each run) never declared it. Maven Central stayed on 1.144.0. pom.xml now declares org.apache.oltu.oauth2.client 1.0.2, the version the generator's own pom uses. The source is regenerated from the current spec with generator 7.21.0 (the version in openapitools.json) so main builds as the release will; OPENAPI_VERSION and the pom version stay at 1.144.0, so the next dispatch still sees a new API version, regenerates and publishes. The generator also gets the real git ids, which replaces the GIT_USER_ID and GIT_REPO_ID placeholders in git_push.sh, and the pom <url> is the homepage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The README was a frozen OpenAPI Generator README from API 1.43.0: it imported org.openapitools.client.* (the packages are com.linkbreakers.*), pinned version 1.43.0, and listed endpoints linking to docs/ files that are never generated. It is now a short hand-written README whose example creates and reads a link with the generated LinksApi methods. scripts/check-docs.sh compiles every Java block in it against the built SDK. It runs on pull requests and in the release workflow after the Maven build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release runs fail at Build with Maven: the spec gained an OAuth2 security scheme so the generated code imports
org.apache.oltu.oauth2, which the hand-kept pom.xml never declared. Maven Central is stuck on 1.144.0.org.apache.oltu.oauth2.client1.0.2 (the generator's own version); pom url is the homepageorg.openapitools.client.*; replaced with a short hand README usingcom.linkbreakersandlinksServiceCreate/linksServiceGetscripts/check-docs.shcompiles every README Java block against the built SDK, on PRs and in the release workflow🤖 Generated with Claude Code