Repository navigation
block: delay support for error injection - #1370
Open
blktests-ci-kpd[bot] wants to merge 3 commits into
Open
blktests-ci-kpd[bot] wants to merge 3 commits into
blktests-ci-kpd[bot] wants to merge 3 commits into
Conversation
Author
|
Upstream branch: 3769bc3 |
blktests-ci-kpd
Bot
force-pushed
the
for-next_base
branch
from
October 1, 2026 15:18
7d0b93f to
b4d7c5e
Compare
Author
|
Upstream branch: 648611e |
blktests-ci-kpd
Bot
force-pushed
the
series/1175637=>for-next
branch
from
October 1, 2026 15:30
901fc2f to
2eda9c1
Compare
blktests-ci-kpd
Bot
force-pushed
the
for-next_base
branch
from
October 3, 2026 09:37
b4d7c5e to
0ca36dd
Compare
Author
|
Upstream branch: 67cd826 |
blktests-ci-kpd
Bot
force-pushed
the
series/1175637=>for-next
branch
from
October 3, 2026 09:46
2eda9c1 to
9736bc2
Compare
Author
|
Upstream branch: 67cd826 |
blktests-ci-kpd
Bot
force-pushed
the
series/1175637=>for-next
branch
from
October 5, 2026 09:03
9736bc2 to
69ae7a9
Compare
blktests-ci-kpd
Bot
force-pushed
the
for-next_base
branch
from
October 5, 2026 13:01
0ca36dd to
d7cbcd8
Compare
Author
|
Upstream branch: 0f7ca97 |
blktests-ci-kpd
Bot
force-pushed
the
series/1175637=>for-next
branch
from
October 5, 2026 13:07
69ae7a9 to
c9e3535
Compare
blktests-ci-kpd
Bot
force-pushed
the
for-next_base
branch
from
October 6, 2026 12:36
d7cbcd8 to
9cd2c96
Compare
Author
|
Upstream branch: c71f470 |
blktests-ci-kpd
Bot
force-pushed
the
series/1175637=>for-next
branch
from
October 6, 2026 13:22
c9e3535 to
e67b003
Compare
blktests-ci-kpd
Bot
force-pushed
the
for-next_base
branch
from
October 7, 2026 23:25
9cd2c96 to
2186464
Compare
Author
|
Upstream branch: 1f50498 |
blktests-ci-kpd
Bot
force-pushed
the
series/1175637=>for-next
branch
from
October 7, 2026 23:46
e67b003 to
a6a3458
Compare
blktests-ci-kpd
Bot
force-pushed
the
for-next_base
branch
from
October 10, 2026 02:04
2186464 to
06b43b2
Compare
Author
|
Upstream branch: 4da93ac |
blktests-ci-kpd
Bot
force-pushed
the
series/1175637=>for-next
branch
from
October 10, 2026 02:50
a6a3458 to
11bc469
Compare
blktests-ci-kpd
Bot
force-pushed
the
for-next_base
branch
from
October 13, 2026 20:59
06b43b2 to
b19ce84
Compare
Author
|
Upstream branch: e8b704b |
blktests-ci-kpd
Bot
force-pushed
the
series/1175637=>for-next
branch
from
October 13, 2026 21:45
11bc469 to
f765d0b
Compare
blktests-ci-kpd
Bot
force-pushed
the
for-next_base
branch
from
October 14, 2026 15:40
b19ce84 to
233d193
Compare
Author
|
Upstream branch: 75b36d2 |
blktests-ci-kpd
Bot
force-pushed
the
series/1175637=>for-next
branch
from
October 14, 2026 16:48
f765d0b to
fb0a072
Compare
blktests-ci-kpd
Bot
force-pushed
the
for-next_base
branch
from
October 15, 2026 14:46
233d193 to
cb90962
Compare
Author
|
Upstream branch: 5219caf |
blktests-ci-kpd
Bot
force-pushed
the
series/1175637=>for-next
branch
from
October 15, 2026 15:25
fb0a072 to
5a499e0
Compare
blktests-ci-kpd
Bot
force-pushed
the
for-next_base
branch
from
October 17, 2026 03:32
cb90962 to
71c4ba0
Compare
Author
|
Upstream branch: 34fbfb9 |
blktests-ci-kpd
Bot
force-pushed
the
series/1175637=>for-next
branch
from
October 17, 2026 04:12
5a499e0 to
2a494bb
Compare
blktests-ci-kpd
Bot
force-pushed
the
for-next_base
branch
from
October 19, 2026 17:31
71c4ba0 to
294ff85
Compare
added 3 commits
October 19, 2026 17:56
tag_to_blk_status() returns BLK_STS_OK both for the "OK" tag and for a tag it does not recognize, so a caller cannot tell the two apart. The block error injection code (which is the sole user of this function currently) relies on error_inject_add() later to reject adding a rule with status=BLK_STS_OK. This is okay for the current state of error injection. The delay option added in the next commit makes the rule with status=OK valid, meaning the function tag_to_blk_status() now needs to explicitly match BLK_STS_OK for it, and fail for a tag it does not recognize. Hence make tag_to_blk_status() take a second param to update the matched status, and return true in case of a successful match. If a match is not found, the function tag_to_blk_status() returns false and *status remains unchanged. A repeated status= where an invalid tag comes first is now rejected instead of being overridden by the later one. Cc: Christoph Hellwig <hch@lst.de> Assisted-by: Claude:claude-opus-5 Signed-off-by: Md Haris Iqbal <haris.iqbal@linux.dev> Reviewed-by: Christoph Hellwig <hch@lst.de>
Error injection can only fail a bio today. Add a delay_us option so that a rule can hold a bio back first, to model a slow device. If a matching rule has delay_us set, the bio is held for that long. It is then failed if the rule also has a status, or resubmitted otherwise. The resubmission is done through submit_bio_noacct_nocheck(), which is where the injection hook sits. To avoid the same delay rule being applied to it again, mark the bio with the BIO_ERROR_INJECTED flag before queueing the work in blk_error_inject_delay(). This also prevents bios that are split later and resubmitted from being evaluated for delay (or error injection) again. __bio_clone() does not propagate the flag, so a clone a stacking driver aims at a lower device is still evaluated. The bio is submitted from a workqueue rather than from the timer, because submitting a bio can sleep. Bios with REQ_NOWAIT are never delayed, and values above 600 seconds are rejected. Cc: Christoph Hellwig <hch@lst.de> Assisted-by: Claude:claude-opus-5 Signed-off-by: Md Haris Iqbal <haris.iqbal@linux.dev>
Document the delay_us option: the delay happens above the driver, a delayed bio is not run through the rules again, and holding a bio back reorders it against bios submitted later. Cc: Christoph Hellwig <hch@lst.de> Assisted-by: Claude:claude-opus-5 Signed-off-by: Md Haris Iqbal <haris.iqbal@linux.dev> Reviewed-by: Christoph Hellwig <hch@lst.de>
Author
|
Upstream branch: f9d56ee |
blktests-ci-kpd
Bot
force-pushed
the
series/1175637=>for-next
branch
from
October 19, 2026 17:57
2a494bb to
04e5f4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: block: delay support for error injection
version: 3
url: https://patchwork.kernel.org/series/1175637/