Skip to content

fix: walk the parent chain safely in CentralDocPage #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Oct 8, 2026
Merged

fix: walk the parent chain safely in CentralDocPage #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions reader/uiframe/CentralDocPage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,10 +891,22 @@ void CentralDocPage::prepareSearch()
docSheet->prepareSearch();
}

// Walk up the fixed three-level parent chain safely: parentWidget() may
// return nullptr at any level (embedded or test environments), and calling
// parentWidget() on a null pointer crashes.
static MainWindow *parentMainWindow(CentralDocPage *page)
{
QWidget *widget = page;
for (int i = 0; i < 3 && widget != nullptr; ++i) {
widget = widget->parentWidget();
}
return widget != nullptr ? dynamic_cast<MainWindow *>(widget) : nullptr;
}

bool CentralDocPage::isFullScreen()
{
// qCInfo(appLog) << "isFullScreen";
MainWindow *mainWindow = dynamic_cast<MainWindow *>(parentWidget()->parentWidget()->parentWidget());
MainWindow *mainWindow = parentMainWindow(this);

if (nullptr == mainWindow)
return false;
Expand All @@ -905,7 +917,7 @@ bool CentralDocPage::isFullScreen()
void CentralDocPage::openFullScreen()
{
qCInfo(appLog) << "openFullScreen";
MainWindow *mainWindow = dynamic_cast<MainWindow *>(parentWidget()->parentWidget()->parentWidget());
MainWindow *mainWindow = parentMainWindow(this);

if (nullptr == mainWindow)
return;
Expand All @@ -925,7 +937,7 @@ void CentralDocPage::openFullScreen()
bool CentralDocPage::quitFullScreen(bool force)
{
qCInfo(appLog) << "quitFullScreen";
MainWindow *mainWindow = dynamic_cast<MainWindow *>(parentWidget()->parentWidget()->parentWidget());
MainWindow *mainWindow = parentMainWindow(this);

if (nullptr == mainWindow)
return false;
Expand Down Expand Up @@ -973,7 +985,7 @@ void CentralDocPage::onSheetCountChanged(int count)
m_tabBar->setVisible(true);
}

MainWindow *mainWindow = dynamic_cast<MainWindow *>(parentWidget()->parentWidget()->parentWidget());
MainWindow *mainWindow = parentMainWindow(this);

if (mainWindow && mainWindow->isFullScreen()) {
qCInfo(appLog) << "mainWindow && mainWindow->isFullScreen()";
Expand Down
Loading