Repository navigation
fix: correct batch print context menu text - #415
Merged
pengfeixx merged 1 commit intoOct 9, 2026
Merged
Conversation
1. Root cause: context-menu config used "Batch Print" without "Document Viewer" prefix; zh_CN/zh_HK/zh_TW all showed "批量打印" missing the required prefix per spec 2. Fix: update Name and Name[locale] fields in deepin-reader-batchprint.conf to match required text 3. Impact: only menu display text changes, no logic affected Log: Updated batch print menu text to include Document Viewer Influence: 1. Verify right-click menu on PDF shows correct text in zh_CN 2. Verify English locale shows "Batch Print with Document Viewer" 3. Verify zh_HK and zh_TW show correct traditional Chinese text fix: 修正批量打印右键菜单文案 1. 根因：右键菜单配置文件中 Name 字段为"批量打印"/"Batch Print"， 缺少"使用文档查看器"前缀，与需求文案不一致 2. 方案：修改 deepin-reader-batchprint.conf 中 Name 及各 locale 字段， 使文案与需求一致 3. 影响：仅菜单显示文案变化，不涉及任何逻辑改动 Log: 修正右键菜单批量打印文案为"使用文档查看器批量打印" Influence: 1. 验证右键PDF文件菜单显示"使用文档查看器批量打印" 2. 验证英文环境下显示"Batch Print with Document Viewer" 3. 验证繁体中文环境显示正确的繁体文案 PMS: BUG-378359
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates four static Name fields in the deepin-reader context-menu configuration so dde-file-manager displays the required Document Viewer batch-print wording across English, zh_CN, zh_HK, and zh_TW locales; no behavior or execution logic changes. Sequence diagram for localized batch-print menu displaysequenceDiagram
participant User
participant DFM as dde-file-manager
participant Config as deepin-reader-batchprint.conf
User->>DFM: Right-click PDF file
DFM->>Config: Read Name locale field
Config-->>DFM: Return localized batch-print text
DFM-->>User: Display Document Viewer batch-print menu
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
📋 提交信息
🔍 详细分析1. 语法逻辑 ✅评分： 25/25 分 ✓ 通过 评价： 语法正确，逻辑清晰 潜在问题： 分析：
2. 代码质量 ✅评分： 25/25 分 ✓ 通过 评价： 代码结构清晰，注释完整 潜在问题： 分析：
3. 代码性能 ✅评分： 20/20 分 ✓ 通过 评价： 性能良好，资源使用合理 潜在问题： 分析：
4. 代码安全 🔒评分： 30/30 分 ✓ 通过 评价： 存在0个安全漏洞
安全漏洞详情： 漏洞对比统计：新增漏洞 0 个，减少漏洞 0 个，持平 0 个 分析：
📝 变更详情
💡 改进建议本次变更质量良好，无需额外改进。变更与 commit message 所述目的完全一致，仅涉及菜单显示文案修正，不涉及任何逻辑改动。 📊 评分汇总
本报告由 AI 代码审查工具自动生成 |
lzwind
approved these changes
Oct 9, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause Analysis
The right-click context menu for PDF files in the file manager displayed "批量打印" (Batch Print) instead of the required "使用文档查看器批量打印" (Batch Print with Document Viewer). The menu text is defined directly in
deepin-reader's context-menu config file (deepin-reader-batchprint.conf), whichdde-file-managerreads and displays. The config file'sNameandName[locale]fields were written with abbreviated text that didn't match the specification.Fix
Updated 4 text fields in
src/context-menus/deepin-reader-batchprint.confto match the required wording:Name,Name[zh_CN],Name[zh_HK], andName[zh_TW]. No logic changes — only display text.Change Safety Assessment
Code Safety
.confconfiguration file; no code logic, function signatures, or call chains are affected.Business Impact Scope
Affects the right-click context menu text shown when users select a PDF file in the file manager. The "Batch Print" menu item text changes to include the "Document Viewer" prefix in English, Simplified Chinese, Traditional Chinese (HK), and Traditional Chinese (TW).
Verification Suggestion
根因分析
文件管理器中右键 PDF 文件时，菜单显示"批量打印"而非需求要求的"使用文档查看器批量打印"。菜单文案由 deepin-reader 的右键菜单配置文件
deepin-reader-batchprint.conf直接定义，dde-file-manager 读取该配置展示菜单项。配置文件中的Name及Name[locale]字段使用了简短文案，与需求不一致。修复方案
修改
src/context-menus/deepin-reader-batchprint.conf中 4 个文案字段（Name、Name[zh_CN]、Name[zh_HK]、Name[zh_TW]），使文案与需求一致。不涉及任何逻辑改动。改动安全评估
代码安全评估
.conf配置文件中的静态显示文案，不涉及代码逻辑、函数签名或调用链。业务影响范围
影响用户在文件管理器中右键 PDF 文件时看到的"批量打印"菜单项文案。英文、简体中文、繁体中文（香港）和繁体中文（台湾）环境下的菜单文案均会变更为包含"文档查看器"前缀的完整文案。
验证建议
Summary by Sourcery
Bug Fixes: