agent simulation: add dispatch_agent_name to SimulationRun.Create.Request - #1793
Open
u9g wants to merge 1 commit into
Open
agent simulation: add dispatch_agent_name to SimulationRun.Create.Request#1793u9g wants to merge 1 commit into
u9g wants to merge 1 commit into
Conversation
…uest agent_name becomes the agent under test as named in livekit.toml, stable across runs so list/counts filters and the dashboard group by it. dispatch_agent_name, when set, is the explicit-dispatch name the simulator sends jobs to; unset dispatches to agent_name, so existing callers are unchanged.
🦋 Changeset detectedLatest commit: 4c114a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Simulation runs are stored and filtered by
agent_name(list and counts requests, the dashboard's agent column). Today the CLI sends a throwawaysimulation-<random>dispatch name in that field when it spawns the agent locally, so every run has a unique name and filtering by agent groups nothing. The random name is required: a locally spawned worker must not collide with the deployed agent's dispatch name.What
agent_nameonSimulationRun.Create.Requestis now the agent under test, as named in the project'slivekit.toml. It is stable across runs, so the existing filters and dashboard grouping become meaningful with no changes to the list or counts requests.optional string dispatch_agent_name = 14: the explicit-dispatch name the simulator sends jobs to. Unset dispatches toagent_name, so existing callers are unchanged.Downstream: livekit/agents-private#446 (dispatch on the new field), livekit/livekit-cli#972 (write
[agent] nameto livekit.toml and send both names), livekit/web#6131 (agent filter on the runs list).