Add SegmentedFileOutput.segment_duration_seconds - #1829
Open
biglittlebigben wants to merge 2 commits into
Open
biglittlebigben wants to merge 2 commits into
biglittlebigben wants to merge 2 commits into
Conversation
segment_duration is a uint32 of whole seconds, which cannot express short segments. Add a double alongside it and deprecate the old field. Consumers should prefer the new field, and fall back to segment_duration when it is the only one set, so existing clients keep working. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 3eeed04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
segment_durationis auint32of whole seconds, which cannot express short segments. This addssegment_duration_seconds, adouble, and deprecatessegment_duration.Consumers should prefer the new field and fall back to
segment_durationwhen it is the only one set, so existing clients keep working.Adopted in livekit/egress#1420.
🤖 Generated with Claude Code