Skip to content

fix(api): report a missing sha256 claim in WebhookReceiver #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasIO merged 1 commit into from
Oct 14, 2026
Merged

fix(api): report a missing sha256 claim in WebhookReceiver #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion livekit-api/livekit/api/webhook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def __init__(self, token_verifier: TokenVerifier):

def receive(self, body: str, auth_token: str) -> WebhookEvent:
claims = self._verifier.verify(auth_token)
if claims.sha256 is None:
if not claims.sha256:
raise Exception("sha256 was not found in the token")

body_hash = hashlib.sha256(body.encode()).digest()
Expand Down
9 changes: 9 additions & 0 deletions tests/api/test_webhook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,15 @@ def test_bad_hash() -> None:
receiver.receive(TEST_EVENT, jwt)


def test_missing_hash() -> None:
token_verifier = TokenVerifier(TEST_API_KEY, TEST_API_SECRET)
receiver = WebhookReceiver(token_verifier)

jwt = AccessToken(TEST_API_KEY, TEST_API_SECRET).to_jwt()
with pytest.raises(Exception, match="sha256 was not found"):
receiver.receive(TEST_EVENT, jwt)


def test_invalid_body() -> None:
token_verifier = TokenVerifier(TEST_API_KEY, TEST_API_SECRET)
receiver = WebhookReceiver(token_verifier)
Expand Down
Loading