lkl: drop libarchive cptofs dependency - #644
Merged
Merged
Conversation
Author
|
This sees the cptofs build enabled on Windows, which fails with: |
ddiss
marked this pull request as draft
September 23, 2026 23:26
ddiss
force-pushed
the
cptofs_libarchive
branch
from
September 28, 2026 06:27
765be37 to
89e9b94
Compare
Unlike fs2tar, cptofs doesn't appear to use libarchive in any way. The dependency appears to have been added by accident via commit 2030bf6 ("lkl tools: improve the build system"). cptofs depends on argp.h, so add and use a new LKL_HOST_CONFIG_ARGP config to avoid Windows and Android build failures. We could consider using https://packages.msys2.org/packages/libargp-devel and / or https://android.googlesource.com/platform/external/argp-standalone in future. Signed-off-by: David Disseldorp <ddiss@suse.de>
ddiss
force-pushed
the
cptofs_libarchive
branch
from
September 28, 2026 06:59
89e9b94 to
af4f4b3
Compare
Author
|
|
ddiss
marked this pull request as ready for review
September 28, 2026 08:06
tavip
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike fs2tar, cptofs doesn't appear to use libarchive in any way. The dependency appears to have been added by accident via commit 2030bf6 ("lkl tools: improve the build system").