Repository navigation
Keep no-op PR edits from cancelling in-flight lint runs - #773
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lint workflow's concurrency group cancels in-progress runs for the same ref. An
editedevent that doesn't change the base branch skips the SwiftFormat job, but it still joined that group and cancelled any lint run already in progress. A PR edited shortly after opening (e.g. #759) is then left with a cancelled and a skipped SwiftFormat check, and stays blocked on the required check.Edits that don't change the base branch now get a unique concurrency group, so they can't cancel a real lint run. Base-branch changes, opens, syncs and reopens behave as before.