Skip to content

docs: note who can create workstation release branches - #938

Merged
thomson-t merged 1 commit into
mainfrom
docs/release-workstation-branch-protection
Oct 14, 2026
Merged

thomson-t merged 1 commit into
mainfrom
docs/release-workstation-branch-protection

Conversation

@thomson-t

Copy link
Copy Markdown
Contributor

Why

The release guide says both release workflows run on main and on workstation/* branches, but it does not say who can create a workstation branch or how changes reach one. Once this lands, the guide states that only the SDK team can create one, and that it then takes changes only through an approved pull request.

Programme

Standalone fix, no programme.

What changes

Before: the release guide named the branches the release environment admits, and nothing more about them.

After: the guide states both rules. The rule restricting branch creation to the SDK team was added on 14 October 2026; the pull-request rule already existed.

Start reading at the new sentence under "Release workflows", and check first that it matches the repository's branch rules. Deliberately left alone: the workflows themselves, and anything about main.

Linked work

None.

Rollout

Nothing reaches production behaviour; if this is wrong, revert the pull request.

Risks

  • the sentence describes repository settings that live outside the code, so it can go stale if those settings change; not addressed; a reviewer would see it disagree with the repository's branch rules

Risk class: low.

Who

Written by: an automated coding agent (Claude Code), working for a maintainer who asked for this change.

Code reviewed before opening: an independent review agent, 14 October 2026; it checked the sentence against the live branch rules, found nothing blocking, and its wording suggestion is applied.

Design reviewed before opening: no one.

Decision this implements: a maintainer's request on 14 October 2026; there is no public record.

Checked: the repository's branch rules and release environment, read on 14 October 2026.

Not checked: nothing else; no code changes.

Size

Hand-written: 2 lines changed (added plus removed) in 1 file.

Generated: none.

🤖 Generated with Claude Code

Release - Publish and Release - Draft run in the release environment
on main and on workstation/* branches. Document that only the SDK team
can create a workstation/* branch and that those branches take changes
only through an approved pull request.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Kotlin migration progress

No change to the Java left to convert.

Module Kotlin LOC Java LOC Java staying (facade) Java left to convert Kotlin share
android-core 3,249 22,594 9,650 12,944 12.6%
android-kit-base 601 5,405 1,651 3,754 10.0%
Total 3,850 27,999 11,301 16,698 12.1%

Conversion progress: 0.0% (16,698 of 16,550 baseline Java LOC left to convert). 132 Java files and 36 Kotlin files in scope.

@github-actions

Copy link
Copy Markdown

Binary compatibility

  • ✅ android-core is compatible with 6.1.8 (115 classes compared, 0 with additions only).
  • ✅ android-kit-base is compatible with 6.1.8 (44 classes compared, 2 with additions only).

Compares the release AAR against the same artifact at the last version published to Maven Central; R8-renamed classes and members are excluded (see the script docstring). Full japicmp HTML/XML reports are attached as the api-compat-reports workflow artifact. This check is not in the required-check set yet, so a red result here does not block merging.

@github-actions

Copy link
Copy Markdown

📦 SDK Size Impact Report

What the SDK adds to a minified release APK.

mParticle Core SDK

Measured against an empty baseline app. Unlike the Rokt kit, android-core ships no Compose and no resources, so there is nothing here that a host app would already provide.

Metric Target branch This PR Change
APK size 120.30 KB 120.29 KB -1 bytes
Download size 118.11 KB 118.11 KB -1 bytes
Dex bytes 214.54 KB 214.54 KB 0 bytes

mParticle Core + Rokt kit

Measured against a Compose + Material3 reference app, so these are the costs on top of an app that already ships Compose. The reference app's dependencies are a documented convention, not a measured average: see size-report-rokt/README.md.

Metric Target branch This PR Change
APK size 1.26 MB 1.26 MB 0 bytes
Download size 1.24 MB 1.24 MB -4 bytes
Dex bytes 2.23 MB 2.23 MB 0 bytes

Rokt SDK+ umbrella (adds the payment extension)

Metric Target branch This PR Change On top of mParticle Core + Rokt kit
APK size 6.55 MB 6.55 MB 0 bytes +5.29 MB
Download size 6.43 MB 6.43 MB 0 bytes +5.19 MB
Dex bytes 7.11 MB 7.11 MB 0 bytes +4.88 MB

➡️ SDK size impact change is minimal.

Raw measurements

core, Target branch:

{"baseline_dex_bytes": 0, "baseline_download_bytes": 2513, "baseline_install_bytes": 7529, "core_dex_bytes": 219692, "core_download_bytes": 123460, "core_install_bytes": 130712}

core, This PR:

{"baseline_dex_bytes": 0, "baseline_download_bytes": 2509, "baseline_install_bytes": 7526, "core_dex_bytes": 219692, "core_download_bytes": 123455, "core_install_bytes": 130708}

rokt, Target branch:

{"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4163396, "kit_download_bytes": 2544133, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9284332, "sdkplus_download_bytes": 7981260, "sdkplus_install_bytes": 8165359}

rokt, This PR:

{"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4163396, "kit_download_bytes": 2544129, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9284332, "sdkplus_download_bytes": 7981260, "sdkplus_install_bytes": 8165359}

Measured 43096be merged into 998eb29

@thomson-t
thomson-t marked this pull request as ready for review October 14, 2026 18:59
@thomson-t
thomson-t requested a review from a team as a code owner October 14, 2026 18:59
@thomson-t
thomson-t merged commit c45d3a8 into main Oct 14, 2026
90 of 91 checks passed
@thomson-t
thomson-t deleted the docs/release-workstation-branch-protection branch October 14, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants