Repository navigation
Conversation
A rate_limit_event after a failed or missing probe was rebuilt as a complete one-window list. Copy unavailable onto the merge the same way resetCredits is copied so the snapshot stays incomplete until a successful probe replaces it.
Owner
Author
|
Superseded by upstream pingdotgg#12700 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Fixes pingdotgg#12170.
applyUsageLimitsUpdatenow copiesunavailableonto the rebuilt snapshot the same way it already copiesresetCredits. A sparserate_limit_eventmerged ontoprobeFailedor onto no previous snapshot stays marked incomplete instead of publishing as a one-window complete list. Unchanged updates keep the previous object (so aprobeFailedno-op no longer rebuilds and strips the marker).unsupportedis still rejected.resolveUsageLimitsAfterProbeis unchanged: a snapshot that still hasunavailableis not last-good, so a later failed probe does not keep weekly-only as complete. Cache hydration and apartialUI reason are out of scope.Why
After a failed (or missing) usage probe, Claude's one-window
rate_limit_eventwas upserted onto[]and rebuilt withoutunavailable. Clients treated that as a full read and drew only the weekly bar; the next failed probe kept it because the marker was gone.pingdotgg#12294 landed the same merge fix and was closed against the V2 provider rewrite. The hole is still on
main; this is the triage's small server bugfix, not a new limits protocol and not blocked on pingdotgg#10597.UI Changes
No new UI. While the marker stays on, Limits keeps showing "Could not read limits." instead of a false weekly-only card. Screenshots/video not applicable.
Tests
vp test run src/provider/providerUsageLimits.test.ts src/provider/makeManagedServerProvider.test.tsinapps/server: 19 passed, including the new merge/probeFailedregressions and the existing "keeps live usage windows across a failed probe". Lint and format clean on the two files.Checklist