Repository navigation
Conversation
…editor is a Windows command shim (pingdotgg#17749) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…utput (pingdotgg#17376) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… again (pingdotgg#17379) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…its thread (pingdotgg#17327) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…a check is still going (pingdotgg#17344) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
…ingdotgg#17496) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…dotgg#17223) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Yash Singh <saiansh2525@gmail.com>
…ingdotgg#17843) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…g#17724) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
… full-access MCP grants (pingdotgg#17772) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pull request (pingdotgg#12223) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Julius Marminge <jmarminge@gmail.com> Signed-off-by: Loïs Postula <lois@postu.la>
…g#18608) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…page (pingdotgg#18666) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#16554) Co-authored-by: PR Batch Tester <agent@local.test> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… you to a new draft (pingdotgg#18672) Co-authored-by: PR Batch Tester <agent@local.test> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ct (pingdotgg#18824) Co-authored-by: PR Batch Tester <agent@local.test> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…stead of crash-looping (pingdotgg#15925) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: PR Batch Tester <agent@local.test>
… resync after a downgrade (pingdotgg#15937) Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: PR Batch Tester <agent@local.test>
… MCP servers (pingdotgg#17058) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Yash Singh <saiansh2525@gmail.com>
…ught (pingdotgg#18887) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
…ingdotgg#18878) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…is offline (pingdotgg#18698) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…18853) Co-authored-by: SAPHID <saphid@users.noreply.github.com> Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
…gdotgg#18709) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
pingdotgg#18900) Co-authored-by: Pawel Mikolajczuk <pmikolajczuk@atlassian.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Chrome refuses to start its sandbox as uid 0, and Playwright rewrites that abort so it was diagnosed as an AppArmor failure. Name the root workarounds instead, and make browser setup warn rather than report the host ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening a preview while the server runs as root fails because Chrome will not start its sandbox as uid 0. Playwright rewrites that abort to "Chromium sandboxing failed!", and the server reports it as an AppArmor problem.
t3 browser setupthen says the host is ready, so the suggested fix cannot resolve the failure.Change
When the process uid is 0 and the sandbox is still on, launch diagnosis returns a separate root error. It names both workarounds: run the service as a nonroot
User=, or setT3CODE_SERVER_BROWSER_SANDBOX=0. It does not mention AppArmor ort3 browser setup.t3 browser setupwarns about that same condition instead of saying the host is ready. Asudoinvocation from a non-root user still reports ready when the AppArmor and library checks pass, because that process is root only for setup. Non-root AppArmor and library diagnosis is unchanged.The server also logs the root warning at startup, before a tab is opened.
Scope and approval
Fixes pingdotgg#18938. The accepted scope on that issue is the root diagnosis and the setup ready message.
Verification
vp test runon:apps/server/src/preview/PreviewBrowserHost.test.tsapps/server/src/cli/browser.test.tsapps/server/src/preview/ServerBrowserStream.test.ts25 tests passed. A root process with the sandbox on reports the root error and does not mention AppArmor or browser setup. A non-root sandbox failure still reports AppArmor. Setup for a root service prints the warning; setup for a non-root user, and
sudosetup for a non-root user, still prints ready. Server package typecheck reported no errors.Fixes pingdotgg#18938
Model and harness: Grok 4.7 (high effort) in a Cursor Cloud Agent.