Repository navigation
Conversation
BREAKING CHANGE: InboundThreadMessage no longer has delivery_status, delivered_at and bounced_at; read them from delivery instead.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (37)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Ruby client adds inbox-scoped inbound forward-rule operations. Inbound messages and threads expose forwarding outcomes, and thread messages expose delivery details. Thread listing also accepts an optional search query. ChangesInbound forwarding and threads
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The forwarding destination in the test recording is masked, and no issue remains that needs resolution before merging. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 36.84% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 19 functions across 25 files. (12 skipped: 12 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds the inbound forwarding API: CRUD for an inbox's forward rules, the outcome of each forward on received messages, and the delivery outcome of sent thread messages. Also adds search to the threads list.
Breaking change:
InboundThreadMessageno longer hasdelivery_status,delivered_atandbounced_at. Read them from the newdeliveryobject instead.Changes
Mailtrap::InboundForwardRulesAPIwithlist,get,create,updateanddeleteInboundForwardRule,InboundForwardRuleCondition,InboundForwardRuleDestination,InboundForwardOutcomeandInboundThreadMessageDeliverystructsforwardsonInboundMessageandInboundThreadMessagedelivery(to,status,delivered_at,bounced_at) on sent thread messages, replacingdelivery_status,delivered_atandbounced_atsearch:keyword onInboundThreadsAPI#list, combinable withlast_id:Summary by CodeRabbit