feat(budget): source_anomalies and account_category on budget accounts - #22
Draft
makegov-mark[bot] wants to merge 2 commits into
Draft
makegov-mark[bot] wants to merge 2 commits into
makegov-mark[bot] wants to merge 2 commits into
Conversation
Supports the Tango API 5.7.0 budget-account contract change. `BudgetAccount` gains `account_category` and `source_anomalies`, typed by the new `BudgetSourceAnomaly`, `BudgetSourceAnomalySource` and `BudgetSourceAnomalyRow` interfaces with every property optional. `ListBudgetAccountsOptions` types `account_category`, `account_category__in` and `agency`. Re-vendors the contract for 5.7.0, regenerates the shape overlay, and baselines Federal Register documents as a not-yet-ported resource. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Supports the Tango API 5.8.0 budget-account field `data_through_period`: the File A fiscal period (1-12) an account-year's figures run through, null with no File A data. `BudgetAccount` gains the field, and `ListBudgetAccountsOptions` types the `data_through_period`, `data_through_period__gte`, `data_through_period__lte` and `data_through_period__isnull` filters. Re-vendors the contract at 5.8.0 and regenerates the shape overlay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supports the Tango API 5.7.0 and 5.8.0 changes to
/api/budget/accounts/:account_category,source_anomalies, anddata_through_period(the File A fiscal period, 1–12, an account-year's figures run through; null with no File A data) with itsdata_through_period/__gte/__lte/__isnullfilters.BudgetAccountgainsaccount_category("budgetary"or"credit_financing"today, typed as an open string) andsource_anomalies([]when the row is clean).BudgetSourceAnomaly,BudgetSourceAnomalySourceandBudgetSourceAnomalyRow; every property is optional and nullable,codeis an open string, andactionis"capped" | "flagged"widened to string.ListBudgetAccountsOptionstypesaccount_category,account_category__in, and theagencyfilter the API already accepted (it was flagged as index-signature-only by the conformance gate).docs/API_REFERENCE.mddocument the new default ordering (nullenacted_balast) and that there is no anomaly filter.contracts/filter_shape_contract.jsonfor 5.7.0 and regeneratedsrc/shapes/generatedOverlay.ts. Federal Register documents appear in the contract without an SDK method yet, sofederal_registeris baselined as a tracked gap in both conformance baselines, matching how eBuy requests were handled.Testing
npx vitest run: 48 files, 439 tests pass (new: filter wire params,source_anomaliesround-trip, and shape resolution ofaccount_category,source_anomaliesonBudgetAccount).npm run typecheck,npm run lint,npm run build: clean.npm run check-conformance: 0 errors.npm run check-shape-coverage: 0 new gaps.No version bump or release.
🤖 Generated with Claude Code