feat(vehicles): add holder_count and order_winner_count; deprecate awardee_count - #23
Draft
makegov-mark[bot] wants to merge 1 commit into
Draft
makegov-mark[bot] wants to merge 1 commit into
makegov-mark[bot] wants to merge 1 commit into
Conversation
…ardee_count Tango API 5.8.0 adds two company counts to vehicles: `holder_count` (distinct companies holding one of the vehicle's IDVs) and `order_winner_count` (distinct companies that have won a task order under it). `awardee_count` becomes a deprecated alias of `order_winner_count`. Both new fields join the `VEHICLES_MINIMAL` and `VEHICLES_COMPREHENSIVE` defaults, the `Vehicle` model, and the explicit shape schema. Re-vendors the API contract at 5.8.0, regenerates the shape overlay, and baselines the not-yet-ported Federal Register resource as a tracked gap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the two vehicle company counts introduced in Tango API 5.8.0 and deprecates the old one.
holder_count: number of distinct companies holding one of the vehicle's IDVs.order_winner_count: number of distinct companies that have won a task order under the vehicle.awardee_count: now marked@deprecated(same value asorder_winner_count); the API keeps serving it until its next major version.Both new fields are added to the
Vehiclemodel, the explicit shape schema, and theVEHICLES_MINIMAL/VEHICLES_COMPREHENSIVEdefaults, right next toawardee_count, matching the API's own default list and detail shapes.Neither is orderable or filterable.
The vendored contract is refreshed to 5.8.0 and the shape overlay regenerated.
That refresh also carries fields the API added between 5.1.0 and 5.8.0 (picked up by the generated overlay) and a new Federal Register resource with no SDK method yet, which is baselined as a tracked gap in both conformance gates, the same way eBuy requests were.
Why
Keeps the SDK's default vehicle shapes in step with the API and gives callers the clearer
order_winner_countname beforeawardee_countgoes away.Merge timing
Merge only after Tango API 5.8.0 is deployed. Until then the API would reject the new fields in the default vehicle shapes.
Testing
npx vitest run tests/unit: 329 passed, including the updated default-shape parity tests and a list-vehicles parse test carrying all three counts.npm run typecheck,npm run lint: clean.npm run check-conformance,npm run check-shape-coverage: pass;npm run generate-shape-overlayproduces no further diff.vehicles.test.ts(list with default shape, search by program) andedge-cases.test.ts(disallowed vehicles ordering). The cassettes need re-recording against the live API once 5.8.0 is deployed; this PR deliberately does not re-record them.🤖 Generated with Claude Code