Repository navigation
fix(idvs): return the pagination cursor from the IDV list methods - #77
Merged
Merged
Conversation
list_idvs, list_idv_awards, list_idv_child_idvs and list_idv_transactions built their PaginatedResponse without the API's cursor, so response.cursor was always None and any caller following it stopped after the first page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
list_idvs(),list_idv_awards(),list_idv_child_idvs()andlist_idv_transactions()now pass the API'scursorthrough to thePaginatedResponsethey return.Why
All four accepted a
cursorargument but dropped the one the API sent back, soresponse.cursorwas alwaysNone. Any caller that follows the cursor (as the contracts, OTA and OTIDV methods already allow) stopped after the first page of at most 100 records. Those four were the onlylist_*methods with this gap.Testing
test_idv_list_methods_return_cursorcovers all four methods; it fails on all four against the pre-fix client and passes with the fix.uv run pytest tests -m "not integration": 463 passed.Next steps
A patch release (1.11.1) so downstream consumers can pick it up.
🤖 Generated with Claude Code