feat: vehicle holder_count/order_winner_count and budget data_through_period (API 5.8.0) - #80
Merged
Merged
Conversation
…ardee_count Tango API 5.8.0 adds two company counts to vehicles: `holder_count` (distinct companies holding one of the vehicle's IDVs) and `order_winner_count` (distinct companies that have won a task order under it). Both join the default `VEHICLES_MINIMAL` and `VEHICLES_COMPREHENSIVE` shapes and the explicit vehicle schema. `awardee_count` is documented as deprecated, since it is the same value as `order_winner_count`. Re-vendors the 5.8.0 contract and regenerates the shape overlay; the contract's new budget-account `data_through_period` filters are baselined until the SDK adds them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tango API 5.8.0 adds `data_through_period` to budget accounts: the File A period (1-12) an account-year's figures run through. It joins the default `BUDGET_ACCOUNTS_MINIMAL` shape and the generated budget-account schema (typed `int`), and `list_budget_accounts()` gains `data_through_period`, `data_through_period_gte`, `data_through_period_lte` and `data_through_period_isnull` filters. The conformance baseline entries for those filters are removed now that the SDK exposes them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The default vehicle shapes now request holder_count and order_winner_count, so the recorded request URLs changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the fields Tango API 5.8.0 introduces.
Added
holder_countandorder_winner_count.holder_countis the number of distinct companies holding one of the vehicle's IDVs.order_winner_countis the number of distinct companies that have won a task order under the vehicle. Both are inVEHICLES_MINIMALandVEHICLES_COMPREHENSIVE, the explicit vehicle schema, and theVehiclemodel.data_through_period(separate commit). The File A period (1-12) an account-year's figures run through; below 12 the year is partial. It is inBUDGET_ACCOUNTS_MINIMAL, andlist_budget_accounts()gainsdata_through_period,data_through_period_gte,data_through_period_lteanddata_through_period_isnullfilters.Deprecated
awardee_count. It is the same value asorder_winner_count, and the API removes it at its next major version. It stays in the default shapes for now and is marked deprecated in the docs and changelog.Changed
contracts/filter_shape_contract.jsonat API 5.8.0, regeneratedtango/shapes/generated_overlay.py, and added the new fields' types tocontracts/observed_shape_types.json.Why
Keeps the SDK's default shapes and filters in line with the API contract, so callers get the new counts without a custom shape and the conformance gates stay green.
Merge order
Merge only after Tango API 5.8.0 is deployed. The default vehicle and budget-account shapes now name fields that older API versions reject, so releasing this first would break default
list_vehicles(),get_vehicle()andlist_budget_accounts()calls.Testing
uv run pytest tests/ -m "not integration": 470 passed, 30 skipped.data_through_periodfilters (including__isnullastrue/false) reach the request and the field parses.ruff format --check,ruff checkandmypyclean ontango/and the touched test file.check_filter_shape_conformance.pyandcheck_shape_coverage.pypass with no new baseline entries.tests/integration/test_vehicles_idvs_integration.pyfail replay because the default shape in the request changed. Their cassettes need re-recording against the live API once 5.8.0 is deployed; they are deliberately not re-recorded here.🤖 Generated with Claude Code