Repository navigation
[GIT-353] fix(ui): anchor portaled CustomSelect and CustomSearchSelect dropdowns correctly - #9890
Closed
shivbera18 wants to merge 1 commit into
Closed
shivbera18 wants to merge 1 commit into
shivbera18 wants to merge 1 commit into
Conversation
…t dropdowns correctly
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
Author
|
Closing this draft PR as the issue is already resolved on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9886
Description
In
packages/ui,CustomSelectandCustomSearchSelectplacedref={setPopperElement},style={styles.popper}, and{...attributes.popper}on an inner<div>wrapper inside<Combobox.Options as="ul">.Following the
@headlessui/reactv2 upgrade,<Combobox.Options>intercepts direct children, injectsrole="none", and clones children without propagating inner callback refs. As a result:setPopperElementwas never called with the mounted DOM node, leavingpopperElementasnull.popperInstanceRef.currentremainednull), leaving the portaled menu positioned at default fallback coordinates (position: fixed; left: 0px; top: 0px).document.bodyfrom transformed containers (such asModalCoreor PropelDialogPanelusing CSS transforms),strategy: "fixed"is required to anchor relative to the viewport.Changes made:
ref={setPopperElement},style={styles.popper},{...attributes.popper}, and container styling directly to<Combobox.Options as="ul">, eliminating the intermediate wrapper<div>.staticto<Combobox.Options>inCustomSelectto keep options mounted under the outerisOpen && createPortal(...)guard.strategy: "fixed"tousePopperin both components to properly anchor portaled dropdowns inside transformed dialogs.outline-noneto trigger buttons and<Combobox.Options>to suppress browser default focus rings.Type of Change
Screenshots and Media (if applicable)
Fixed: Workspace Settings - Invite Modal Role Selector
Fixed: Workspace Settings - Members List Role Selector
Test Scenarios
<workspaceSlug>/settings/members.References