Repository navigation
e2e: bump testcontainers-go to 0.44 - #4373
Merged
Merged
Conversation
0.43 moved its request types to github.com/moby/moby/api. Only the types passed to testcontainers move; direct Docker client calls stay on github.com/docker/docker.
ben-dz
marked this pull request as ready for review
September 26, 2026 14:11
juan-malbeclabs
approved these changes
Sep 26, 2026
juan-malbeclabs
left a comment
juan-malbeclabs
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The migration is mechanical: only the types passed to testcontainers move to moby/moby/api, and the direct Docker client calls stay on docker/docker, which keeps the diff small and reviewable. Deferring the moby/moby/client move to its own PR makes sense, and so does holding goose at 3.27.0 given the GOTOOLCHAIN=local images. Two non-blocking nits inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps testcontainers-go and its clickhouse and redpanda modules from 0.40 to 0.44, and clickhouse-go from 2.46 to 2.48. These were held back in #4370: testcontainers 0.43 moved its request types from
github.com/docker/dockertogithub.com/moby/moby/api, and clickhouse-go 2.47+ requires testcontainers 0.43.Only the types handed to testcontainers change:
ConfigModifier,HostConfigModifier,EndpointSettingsModifier,Resources, network IPAM, and wait/mapped ports, which are now plain strings. Direct Docker client calls (dockerClient.ContainerList, filters, inspect) stay ongithub.com/docker/docker, so go.mod now carries both. Moving those calls togithub.com/moby/moby/clientis a larger rewrite, and it can be done separately.The moby types use
netipfor IPs and subnets. The CYOA IPs for the client and ip-verifier and the network subnets are now parsed before use, and a bad value returns an error instead of being passed through as a string.goose stays at 3.27.0. 3.27.3 requires go 1.25.7, and the test and release images build on
golang:1.25.0/1.25.5, which setGOTOOLCHAIN=localand can't fetch a newer toolchain. Rust and Solana dependencies are untouched.Testing Verification
All six e2e shards and the three shard-e2e jobs pass in CI, and so do the container tests (
go-container-test) andgo-test. Locally,go vetis clean under every build tag in the repo (none,qa,e2e,e2e,stress,container_tests), and golangci-lint reports no issues.