Skip to content

allow user to create new geojson layer, define active layer, drag&dro… - #911

Merged
digitaltom merged 12 commits into
mainfrom
user_layers
Sep 26, 2026
Merged

digitaltom merged 12 commits into
mainfrom
user_layers

Conversation

@digitaltom

Copy link
Copy Markdown
Collaborator

…p features between layers

Copilot AI lite review requested due to automatic review settings September 26, 2026 12:01

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@digitaltom
digitaltom requested a lite review from Copilot September 26, 2026 20:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Unresolved moderate issues affect collaborative layer ordering, visibility controls, and layer-aware undo/redo.

Review effort: Lite
Findings: 3 Medium severity

Open (3)
Resolved since last review (3)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Preserve originating layer in feature undo state

app/​javascript/​maplibre/​layers/​layers.js:300

Feature undo states do not record their layer, while the new fallback here chooses the current active layer. If a feature is added or deleted in layer A, the user switches the active layer to B, and then undoes/redoes that operation, undo.js calls addFeature(state) and restores it in B; the server then infers B as well. Preserve the originating layer id in feature undo state and pass it to addFeature/new_feature so undo remains tied to the layer where the edit occurred.

@digitaltom
digitaltom merged commit 24406c2 into main Sep 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants